Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow dns discovery in transfer example #3121

Merged
merged 5 commits into from
Jan 13, 2025
Merged

feat: allow dns discovery in transfer example #3121

merged 5 commits into from
Jan 13, 2025

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Jan 13, 2025

Description

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Arqu Arqu self-assigned this Jan 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3121/docs/iroh/

Last updated: 2025-01-13T12:04:31Z

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 21c7ff3

Base automatically changed from arqu/bump_pkarr to main January 13, 2025 11:37
@Arqu Arqu marked this pull request as ready for review January 13, 2025 11:38
flub
flub approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I do think you shouldn't call that a dns_url. There's nothing URL about it.

iroh/examples/transfer.rs Outdated Show resolved Hide resolved
iroh/examples/transfer.rs Outdated Show resolved Hide resolved
iroh/examples/transfer.rs Outdated Show resolved Hide resolved
@Arqu Arqu added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit a5bb926 Jan 13, 2025
26 checks passed
@Arqu Arqu deleted the arqu/dns_transfer_tests branch January 13, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flub flub flub approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

@matheus23 matheus23 Awaiting requested review from matheus23

Assignees

@Arqu Arqu

Labels
None yet
Projects
iroh
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arqu @flub