refactor(iroh-relay)!: server actor task is not a task or actor anymore #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3093/docs/iroh/ Last updated: 2025-01-03T16:44:30Z |
dignifiedquire
force-pushed
the
dig/relay-server-actors-2
branch
from
bdfd4dd to
0a172d8
Compare
dignifiedquire
changed the title
flub
reviewed
Jan 3, 2025
| // First priority, disco packets | ||
| packet = self.disco_send_queue.recv() => { | ||
| let packet = packet.context("Server.disco_send_queue dropped")?; | ||
| self.send_disco_packet(packet).await.context("send packet")?; |
There was a problem hiding this comment.
This actor still blocks entirely while sending data to the sink. Looking at what else it does:
- cancel_token: will be potentially delayed if a write is slow. May not be ideal if this is used to try and stop a broken client.
- blocks receiving obviously. Not disastrous, but it could be faster.
So all in all this is probably not a serious problem, but rather a potential nice optimisation that could be done later.
dignifiedquire
force-pushed
the
dig/relay-server-actors-2
branch
from
061422d to
c6d64fd
Compare
flub
approved these changes
Jan 3, 2025
| @@ -181,7 +178,7 @@ pub(crate) async fn recv_client_key<S: Stream<Item = anyhow::Result<Frame>> + Un | |||
|
|
|||
| // TODO: variable recv size: 256 * 1024 | |||
| let buf = tokio::time::timeout( | |||
| Duration::from_secs(10), | |||
| std::time::Duration::from_secs(10), | |||
There was a problem hiding this comment.
flags, the import wasn't there anymore
|
Maybe best to wait with merging until the base PR is merged in main so it shows up as a separate commit? |
😭 yes, hopefully rebase will not be too bad.. |
dignifiedquire
force-pushed
the
dig/relay-server-actors-2
branch
from
6a5a78c to
113519b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #3073
Breaking Changes
iroh_relay::server::ClientConnRateLimittoClientRateLimitiroh_relay::server::MaybeTlsStreamServerfrom the public APIiroh_relay::client::SendMessage::NotePreferredNotes & open questions
Change checklist