ci(*): Run flaky tests with --verbose and use ci profile #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix building of tests to use --profile ci which is used to run the tests. The test run did not trigger a re-build. So mosly likely the profile is not encoded in the build artifacts and we were running tests on the normal dev profile rather than the ci profile.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3063/docs/iroh/ Last updated: 2024-12-19T16:26:53Z |
Arqu
reviewed
Dec 19, 2024
Seems like this is a nextest profile, not a cargo profile. Goodness.
Arqu
approved these changes
Dec 19, 2024
Arqu
reviewed
Dec 19, 2024
.github/workflows/tests.yaml
Outdated
| @@ -111,7 +111,7 @@ jobs: | |||
| - name: run tests | |||
| run: | | |||
| mkdir -p output | |||
| cargo nextest run --workspace ${{ env.FEATURES }} --lib --bins --tests --profile ci --run-ignored ${{ inputs.flaky && 'all' || 'default' }} --no-fail-fast --message-format ${{ inputs.flaky && 'libtest-json' || 'human' }} > output/${{ matrix.name }}_${{ matrix.features }}_${{ matrix.rust }}.json | |||
| cargo nextest run --workspace ${{ env.FEATURES }} --lib --bins --tests --profile ci --run-ignored ${{ inputs.flaky && 'all' || 'default' }} ${{ inputs.flaky && '--verbose' }} --no-fail-fast --message-format ${{ inputs.flaky && 'libtest-json' || 'human' }} > output/${{ matrix.name }}_${{ matrix.features }}_${{ matrix.rust }}.json | |||
There was a problem hiding this comment.
Fyi in the test suite this renders as "false" for the CLI command, think you need to add || '' so it returns an empty string when evaluating to false. Which I think is the reason the tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also fix building of tests to use --profile ci which is used to run
the tests. The test run did not trigger a re-build. So mosly likely
the profile is not encoded in the build artifacts and we were running
tests on the normal dev profile rather than the ci profile.
Breaking Changes
Notes & open questions
Change checklist