Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(iroh-net): increase timeout for local swarm discovery test #2574

Merged
merged 13 commits into from
Aug 3, 2024

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Aug 1, 2024

Description

The local_swarm_discovery test was reliably timing out when run on the linux CI. After checking the logs and NOT finding any evidence that anything goes wrong, I increased the timeout and can no longer trigger the failure.

Change checklist

  • Self-review.

@ramfox ramfox self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2574/docs/iroh/

Last updated: 2024-08-02T17:53:10Z

@divagant-martian divagant-martian force-pushed the flaky-local-swarm-discovery branch from a525e99 to 094e8f9 Compare August 1, 2024 19:20
@ramfox ramfox changed the title [wip] Flaky local swarm discovery fix(iroh-net): increase timeout for local swarm discovery test Aug 2, 2024
@ramfox ramfox requested review from flub and divagant-martian August 2, 2024 03:26
@ramfox ramfox changed the title fix(iroh-net): increase timeout for local swarm discovery test test(iroh-net): increase timeout for local swarm discovery test Aug 2, 2024
@ramfox ramfox requested a review from matheus23 August 2, 2024 14:04
@matheus23 matheus23 added this pull request to the merge queue Aug 3, 2024
Merged via the queue into main with commit 605a85d Aug 3, 2024
28 checks passed
@ramfox ramfox deleted the flaky-local-swarm-discovery branch August 5, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants