Skip to content

Commit

Permalink
Use slightly better names
Browse files Browse the repository at this point in the history
  • Loading branch information
matheus23 committed Jan 8, 2025
1 parent 2f0beff commit 43f46f7
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions iroh/src/dns/node_info.rs
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,14 @@ mod tests {
assert_eq!(expected, actual);
}

/// There used to be a bug where uploading a NodeAddr with more than only exactly
/// one relay URL or one publicly reachable IP addr would prevent connection
/// establishment.
///
/// The reason was that only the first address was parsed (e.g. 192.168.96.145 in
/// this example), which could be a local, unreachable address.
#[test]
fn regression_record_parse_multiple_txt_entries() -> TestResult {
fn test_dns_answer_multiple_txt_records() -> TestResult {
let name = Name::from_utf8(
"_iroh.dgjpkxyn3zyrk3zfads5duwdgbqpkwbjxfj4yt7rezidr3fijccy.dns.iroh.link.",
)?;
Expand Down Expand Up @@ -489,7 +495,7 @@ mod tests {
}

#[test]
fn regression_record_parse_bigger_txt_record() -> TestResult {
fn test_record_multiple_values() -> TestResult {
let name = Name::from_utf8(
"_iroh.dgjpkxyn3zyrk3zfads5duwdgbqpkwbjxfj4yt7rezidr3fijccy.dns.iroh.link.",
)?;
Expand Down

0 comments on commit 43f46f7

Please sign in to comment.