Skip to content

Commit

Permalink
refactor(iroh-net): replace flume in iroh-net with async_channel (#2539)
Browse files Browse the repository at this point in the history
## Description

refactor(iroh-net): replace flume in iroh-net with async_channel

Rationale: see n0-computer/iroh#2536

This is the first in a series of PRs that will replace flume with
async_channel. In this case it is very close to a drop in replacement
without any need for changes.

Only noteable changes:

send_async becomes send
send becomes send_blocking
Receiver implements Stream, so no need for .into_stream()
Receiver is not Unpin, so to make it unpin you need to do
`Box::pin(recv)` or use `.boxed()`

## Breaking Changes

None

## Notes & open questions

- Anything specific from flume we were relying on here?

## Change checklist

- [x] Self-review.
- [x] ~~Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.~~
- [x] ~~Tests if relevant.~~
- [x] ~~All breaking changes documented.~~
  • Loading branch information
rklaehn authored Jul 24, 2024
1 parent d902359 commit 3a15cf6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3a15cf6

Please sign in to comment.