[pull] master from chromium:master #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bug: chromium:1077284 Change-Id: I19eed6072dd7854b81f7fa8c25470b18b3bc1ffd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2037803 Commit-Queue: Joshua Peraza <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
This is a reland of b579146695ba0c045d26b022e63d199bd23f8349 Original change's description: > Default to the threadsafe GTest death_test_style. > > Using the default style of "fast" can lead to subtle test flakiness. > And on macOS, most of CoreFoundation is not safe to use after fork() > without exec(). Several //base implementations on Mac use CF, and so it > is almost never safe to use the "fast" death_test_style. > > Change-Id: Idcee977978561e0a57ace20b53f597c566708692 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/570500 > Commit-Queue: Robert Sesek <[email protected]> > Reviewed-by: danakj <[email protected]> > Reviewed-by: Gabriel Charette <[email protected]> > Cr-Commit-Position: refs/heads/master@{#854588} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2747682 Reviewed-by: Sophie Chang <[email protected]> Reviewed-by: Gabriel Charette <[email protected]> Reviewed-by: danakj <[email protected]> Commit-Queue: Robert Sesek <[email protected]> Cr-Commit-Position: refs/heads/master@{#862111} Message-Id: Merged from chromium b374bd6f372ac3ead20ed8b3a53ad1b60bd26b50 Change-Id: I87eae51cb4746183951bf8643f241937b119fa70 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2818148 Reviewed-by: Mark Mentovai <[email protected]>
The //build/confic/mac/BUILD.gn which defines this target does not build properly in some cronet ios build configurations, and the dependency is not necessary for ios builds. Fixed: 1161219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656759 Commit-Queue: Ken Rockot <[email protected]> Auto-Submit: Ken Rockot <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Cr-Commit-Position: refs/heads/master@{#848224} Message-Id: Merged from chromium a9f64a9dbf42e411a38e3c93b131984a0a02a84a Change-Id: Ifd03c41d42b3756cb77bb7cc3ece5d3f23b1262d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2818147 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Robert Sesek <[email protected]>
UI_USER_INTERFACE_IDIOM is deprecated in iOS13. Instead use -[UIDevice userInterfaceIdiom] directly. Bug: crashpad: 31 Change-Id: I0bdcc3b3b42bd2ca87cee26abedbeb5b89632981 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2826575 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Justin Cohen <[email protected]>
There's no default curl available when building on host Linux in the Fuchsia tree, so add an explicit dependency when using the curl transport in Fuchsia. Change-Id: I0afe5e2cc8ea0a70f3ef4e1635d4d808237c93b6 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2832147 Reviewed-by: Joshua Peraza <[email protected]> Commit-Queue: Scott Graham <[email protected]>
Change-Id: I51a57df459f8f3a79f7d2df7a823820bccb55bd0 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2832209 Reviewed-by: Francois Rousseau <[email protected]> Commit-Queue: Scott Graham <[email protected]>
Change-Id: I79c9fcee887b75956c405bf5632d6616c82bd8b8 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2826039 Reviewed-by: Scott Graham <[email protected]> Commit-Queue: Scott Graham <[email protected]>
Bug: chromium:1200488 Change-Id: Ib0f0b81460d53aac1885beb415b45a4a4e1a09fa Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2837602 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Joshua Peraza <[email protected]>
DeepCode's analysis on #66eb80 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )