Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Handle android time with unix seconds not ms + unify API response formats #17

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix: Handle android time with unix seconds not ms + unify API response formats #17

merged 2 commits into from
Apr 30, 2024

Conversation

mym0404
Copy link
Owner

@mym0404 mym0404 commented Apr 30, 2024 •
edited
Loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhance (enhance performance, api, etc)

What does this change?

  • Unify Android, iOS response about time. Android time unit in response was milliseconds not seconds.
  • Match Android serviceTerms response with iOS.
  • Android API response includes null fields if putXXXElseNull failed.
  • Fix Android user ID long type was overflowed by casting to Int. It will be handled as a double now.

Fixes #16 🎯

image

image

@mym0404 mym0404 added bug Something isn't working p:user labels Apr 30, 2024
@mym0404 mym0404 self-assigned this Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-kakao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:23am

@mym0404 mym0404 changed the title fix(user): handle android time with unix seconds not ms + unify service terms response format Fix: Handle android time with unix seconds not ms + unify service terms response format Apr 30, 2024
@mym0404 mym0404 changed the title Fix: Handle android time with unix seconds not ms + unify service terms response format Fix: Handle android time with unix seconds not ms + unify API response formats Apr 30, 2024
@mym0404 mym0404 merged commit a414ade into main Apr 30, 2024
6 checks passed
@mym0404 mym0404 deleted the fix-android-service-terms-response-format branch April 30, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mym0404 mym0404

Labels
bug Something isn't working p:user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: serviceTerms return value is different on Android
1 participant
@mym0404