Support excluding filter on mapper scan feature

[apdya]

fix issue #548. add field ComponentScan.Filter[] excludeFilters() in @MapperScan. Support excluding filter on
mapper scan feature.

[hazendaz]

Few issues I see here

• Add code into deprecated code
• Adding aspectj but doesn't use it at all
• Alignment issues (ie adding properties that are against the next line javadocs)

@kazuki43zoo Will need to check this out but please cleanup items noted and make a case for why deprecated code is being filled out while deprecation was left. Not seeing that was even needed off hand but didn't look deeper than that.

[apdya]

Few issues I see here

• Add code into deprecated code
• Adding aspectj but doesn't use it at all
• Alignment issues (ie adding properties that are against the next line javadocs)

@kazuki43zoo Will need to check this out but please cleanup items noted and make a case for why deprecated code is being filled out while deprecation was left. Not seeing that was even needed off hand but didn't look deeper than that

Few issues I see here

• Add code into deprecated code
• Adding aspectj but doesn't use it at all
• Alignment issues (ie adding properties that are against the next line javadocs)

@kazuki43zoo Will need to check this out but please cleanup items noted and make a case for why deprecated code is being filled out while deprecation was left. Not seeing that was even needed off hand but didn't look deeper than that.

thanks for replying

• issue 1 and 3: I will modify my code and update this pr.
• issue 2: ComponentScan.Filter[] is from spring-context, it supports ASPECTJ FilterType, which need dependency on aspectjweaver, and this dependency is set as optional in spring-context, so this dependency need be added.

[hazendaz]

thanks for updates, few more comments.

[apdya]

thanks for review
I have modified my code as your comment, and explain the reason to import aspectjweaver in that conversation.

[hazendaz]

@kazuki43zoo Can you take a look at this one?

[hazendaz]

@apdya Tests don't build, can you please take a look?

[apdya]

@apdya Tests don't build, can you please take a look?

sorry I haven't run all test in my local project before commit. I update the new added test code just now, and all test passed.

[kazuki43zoo]

Can you take a look at this one?

Just wait a few time!

[kazuki43zoo]

I added some comments.

@apdya

• Could you support this enhancement for the <mybatis:scan>(XML namespace feature)? If you cannot support it, I support it.

• Please perform ./mvnw clean verify (can apply code formatter and update license header)

[apdya]

I added some comments.

@apdya

• Could you support this enhancement for the <mybatis:scan>(XML namespace feature)? If you cannot support it, I support it.
• Please perform ./mvnw clean verify (can apply code formatter and update license header)

@kazuki43zoo
thanks for review
I have modify my code as your comment, and updated this pr.
I would like to support XML namespace feature if this task is not urgent.
mvnw seems not work in my IDEA, i will figure it out soon. and I have add license header to all the new added file.

[apdya]

hi @kazuki43zoo

I have add some code to support exclude filter feature with xml. the new added element in xsd keep unified with Spring.

[apdya]

still need some work

[apdya]

still need some work

with latest commit, exclude-filter has been supported in mybatis:scan and test in org.mybatis.spring.filter.xml.XmlScanFilterTest

[apdya]

@kazuki43zoo Is there anything else I need to change?

[hazendaz]

@apdya Can you fix the merge conflict that exists now?

[apdya]

@apdya Can you fix the merge conflict that exists now?

@hazendaz happy to receive your reply, merge conflict has been resolved. whether this pr can be merged into the master branch now?

[hazendaz]

@apdya I'll try to get to this in a week or two. I believe all was good and just got missed. I've got a reminder to review it again and take care of merging it in. If you could, assuming there isn't one, open an issue that same support needs added to xml namespace as I see commented on here a few times so its not missed in future and at least helps others see that support is not present.

[hazendaz]

as to a release as I'm sure that will come next after merging, probably end of month we could also get a release out.

[coveralls]

coverage: 90.232% (+0.9%) from 89.305%
when pulling b7f3f35 on apdya:scanfilter
into afd3335 on mybatis:master.

[apdya]

@apdya I'll try to get to this in a week or two. I believe all was good and just got missed. I've got a reminder to review it again and take care of merging it in. If you could, assuming there isn't one, open an issue that same support needs added to xml namespace as I see commented on here a few times so its not missed in future and at least helps others see that support is not present.

@hazendaz thanks for reply. <mybatis:exclude-filter >(XML namespace feature) had been supported with commit [82ef68f] in this pr. test case: org.mybatis.spring.filter.xml.XmlScanFilterTest

[hazendaz]

@apdya Merged. I'll try to get a release towards end of the month. If I miss that please do remind me here :)

[apdya]

@apdya Merged. I'll try to get a release towards end of the month. If I miss that please do remind me here :)
@hazendaz sorry for the late reminder, i got the time wrong :(

[hazendaz]

@apdya Sorry for delays. I had a few personal issues that took up most my time last month. So thank you for reminder. I'll work to get this released next week.