Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracle implicit cursor workaround #3387

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

harawata
Copy link
Member

@harawata harawata commented Jan 5, 2025

  • Failing test involving Oracle's multiple result sets
  • Handle multiple result sets (implicit cursor) with Oracle driver

Oracle driver...

... throws `SQLException` with no good reason when calling `Statement#getResultSet()`.
`SQLException` is thrown "if a database access error occurs or this method is called on a closed Statement".
https://docs.oracle.com/en/java/javase/23/docs/api/java.sql/java/sql/Statement.html#getResultSet()
https://stackoverflow.com/q/42091653/1261766

... always returns `false` from `DatabaseMetaData#supportsMultipleResultSets()` even though it apparently does.
@coveralls
Copy link

Coverage Status

coverage: 87.307% (-0.02%) from 87.326%
when pulling f72fe1a on harawata:oracle-implicit-cursor-workaround
into 7939f2a on mybatis:master.

@harawata harawata self-assigned this Jan 5, 2025
@harawata harawata added the enhancement Improve a feature or add a new feature label Jan 5, 2025
@harawata harawata added this to the 3.6.x milestone Jan 5, 2025
@harawata harawata merged commit 6e639f6 into mybatis:master Jan 5, 2025
18 of 19 checks passed
@@ -204,6 +204,12 @@
<version>9.1.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.oracle.database.jdbc</groupId>
<artifactId>ojdbc8</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harawata Don't you want the java 11 version here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍
I'll update later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants