Clean conda-environment-dev.yml
#851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the pinned version for `python-ldap`. Add some explanatory comments. Remove `pip` since it is already a dependency of `python`. Remove `openldap` since it is already a dependency of `python-ldap`.
|
👍 |
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubecore
that referenced
this pull request
Jan 14, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube/mxcubeweb#1510 GitHub: mxcube#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube#851
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubeweb
that referenced
this pull request
Jan 14, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube#1510 GitHub: mxcube/mxcubecore#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube/mxcubecore#851
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubecore
that referenced
this pull request
Jan 17, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube/mxcubeweb#1510 GitHub: mxcube#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube#851
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubeweb
that referenced
this pull request
Jan 17, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube#1510 GitHub: mxcube/mxcubecore#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube/mxcubecore#851
marcus-oscarsson
pushed a commit
to mxcube/mxcubeweb
that referenced
this pull request
Jan 17, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: #1510 GitHub: mxcube/mxcubecore#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube/mxcubecore#851
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubecore
that referenced
this pull request
Jan 17, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube/mxcubeweb#1510 GitHub: mxcube#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube#851
marcus-oscarsson
pushed a commit
that referenced
this pull request
Jan 17, 2025
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube/mxcubeweb#1510 GitHub: #849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: #851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the pinned version for
python-ldap.Add some explanatory comments.
Remove
pipsince it is already a dependency ofpython.Remove
openldapsince it is already a dependency ofpython-ldap.