Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependencies #842

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

fabcor-maxiv
Copy link
Contributor

@fabcor-maxiv fabcor-maxiv commented Jan 19, 2024

Remove formatting and linting dependencies from the conda environment since they are in pre-commit already.

Remove test dependencies from the conda environment since they are in the Poetry dev dependencies already.

Remove code related to importlib_metadata on Python "<3.8".

Remove dependency version constraints for Python "<3.8" since we only support Python ">=3.8,<3.11".

Remove setuptools and setuptools-scm from build dependencies since they are superfluous.

Copy link
Collaborator

@rhfogh rhfogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I have not tested this, but the idea is exactly right

Remove formatting and linting dependencies from the conda environment
since they are in pre-commit already.

Remove test dependencies from the conda environment
since they are in the Poetry dev dependencies already.

Remove code related to `importlib_metadata` on Python "<3.8".

Remove dependency version constraints for Python "<3.8"
since we only support Python ">=3.8,<3.11".

Remove setuptools and setuptools-scm from build dependencies
since they are superfluous.
@fabcor-maxiv fabcor-maxiv force-pushed the simplify-dependencies branch from 45a63bf to 46255a8 Compare January 19, 2024 15:11
@marcus-oscarsson marcus-oscarsson merged commit 60a6eca into mxcube:develop Jan 22, 2024
8 of 9 checks passed
@fabcor-maxiv fabcor-maxiv deleted the simplify-dependencies branch January 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants