Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractAuthenticator fix after revert #830

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

marcus-oscarsson
Copy link
Member

It turns out that the revert and re-apply I made yesterday removed most of the important changes to the PR. I'm very sorry for that. Here is the PR again, its the same PR but with all the files included.

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
mxcubecore/HardwareObjects
   Beamline.py31610966%146–160, 262–269, 302, 324, 368, 379, 401, 457, 469, 480, 491, 513, 524, 537, 548, 559, 570, 581, 592, 603, 614, 625, 637, 652, 663, 676, 687, 702, 713, 724, 740, 756, 773–859, 866–876, 879, 882–893
   LdapAuthenticator.py1021020%7–185
mxcubecore/HardwareObjects/abstract
   AbstractAuthenticator.py13130%22–50
mxcubecore/HardwareObjects/mockup
   ISPyBClientMockup.py2082080%5–725
TOTAL60654561907% 

Tests Skipped Failures Errors Time
1925 0 💤 0 ❌ 0 🔥 1m 34s ⏱️

Copy link
Collaborator

@rhfogh rhfogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not have time to read through this again (and anyway I was never the best judge for an authentication PR). But given that this was already approved once, I am happy to transfer approval to the resubmission.

@marcus-oscarsson marcus-oscarsson merged commit 3166409 into develop Dec 15, 2023
10 checks passed
@marcus-oscarsson marcus-oscarsson deleted the mo-abstract-authenticator-fix branch January 31, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants