ISPyB LIMS: make it possible to use custom ISPyB adapter object #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, thanks ! |
Adds a factory method _create_data_adapter(), which creates an instance of data adapter. This allows to supply different implementation of the adapter objects in custom ISPyB LIMS classes.
marcus-oscarsson
force-pushed
the
ispyb-lims-create-data-adapter
branch
from
f0b307d to
5142a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a factory method
_create_data_adapter(), which creates an instance of data adapter. This allows to supply different implementation of the adapter objects in custom ISPyB LIMS classes.We use a custom data adapter at MAX IV, to implement our site specific features.