Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICAT integration update #1110

Merged
merged 17 commits into from
Jan 30, 2025
Merged

ICAT integration update #1110

merged 17 commits into from
Jan 30, 2025
+444 −173

Conversation

marcus-oscarsson
Copy link
Member

Improvements made to the ICAT integration mostly by @antolinos, @woutdenolf.

  • Emitting signal when the list of available session changes
  • General linting
  • Added metadata for XRF, EnergyScan and Detector

@marcus-oscarsson marcus-oscarsson changed the title Mo icat ICAT integration update Jan 28, 2025
elmjag
elmjag approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@elmjag elmjag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't yet understand all the intricacies of LIMS managment, but this looks good to me.

@marcus-oscarsson marcus-oscarsson merged commit ffea8c1 into develop Jan 30, 2025
10 checks passed
@marcus-oscarsson marcus-oscarsson deleted the mo-icat branch January 30, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmjag elmjag elmjag approved these changes

@antolinos antolinos Awaiting requested review from antolinos

@beteva beteva Awaiting requested review from beteva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcus-oscarsson @elmjag @antolinos @woutdenolf