Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show chapters in ABS audiobook view #1928

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

fmunkes
Copy link
Contributor

@fmunkes fmunkes commented Feb 1, 2025

No description provided.

@fmunkes fmunkes added the bugfix label Feb 1, 2025
This reverts commit e9796c4.
Chapter times were ok, and I was to hasty.
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed, as discussed in discord.
Let's not do it this way but instead fix it at core level.

@fmunkes
Copy link
Contributor Author

fmunkes commented Feb 1, 2025

I close this then, the chapter times appear fine

@fmunkes fmunkes closed this Feb 1, 2025
@marcelveldt marcelveldt reopened this Feb 1, 2025
@marcelveldt
Copy link
Member

I was mistaken. For podcasts its fine to retrieve episodes later/lazy but for audiobooks they really need to be present.
If this causes excessive more requests on your end, please discuss on discord so we can change the model a bit at core level. TIP: just cache the episodes in your provider.

@marcelveldt marcelveldt changed the title fix: show chapters in audiobook view fix: show chapters in ABS audiobook view Feb 1, 2025
@marcelveldt marcelveldt merged commit 5cbfb14 into music-assistant:dev Feb 1, 2025
7 checks passed
@fmunkes fmunkes deleted the abs_fix_chapters branch February 1, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants