Fix: Use Deezer record_type to set the album type of Deezer albums #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type property of an album in the Deezer api contains the resource type, not the album type. The album type is called record_type instead. Make sure to explicitly convert between types, so that we can handle unrecognised album types as "unknown". Additionally, compilations are called "compile" in the Deezer API so we also need to handle that.
awhiemstra
force-pushed
the
work/ahiemstra/albumtype
branch
from
db497f4 to
19d33b3
Compare
marcelveldt
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type property of an album in the Deezer api contains the resource type, not the album type. The album type is called record_type instead.
Make sure to explicitly convert between types, so that we can handle unrecognised album types as "unknown". Additionally, compilations are called "compile" in the Deezer API so we also need to handle that.