Partial ties refinements #26048
Partial ties refinements #26048
Conversation
src/engraving/dom/tie.cpp
Outdated
|
|
||
| return title; | ||
| //: %1 represents the preceding jump item eg. coda. %2 represents the measure number | ||
| return muse::mtrc("engraving", "Tie to %1 (m. %2)").arg(precedingJumpItemName(), measureStr); |
There was a problem hiding this comment.
Sorry, I overlooked that measureNo is an int of course. You could do
return muse::mtrc("engraving", "Tie to %1 (m. %2)")
.arg(precedingJumpItemName(), String::number(measureNo));(Alternatively,
return muse::mtrc("engraving", "Tie to %1 (m. %2)")
.arg(precedingJumpItemName()).arg(measureStr);but that is less performant.)
| @@ -33,7 +33,7 @@ StyledPopupView { | |||
| property alias navigationOrderStart: capoSettingsNavPanel.order | |||
| readonly property alias navigationOrderEnd: capoSettingsNavPanel.order | |||
|
|
|||
| property QtObject model: capoModel | |||
| readonly property alias model: capoModel | |||
There was a problem hiding this comment.
Do we still need this property at all, now that the model.canOpen call no longer happens in QML but in C++?
| #pragma once | ||
| #include "global/types/string.h" | ||
|
|
||
| using muse::String; |
There was a problem hiding this comment.
using … in header files is not really preferred because it may cause conflicts in other cpp files that include this header file. In this case I'd just write muse::String.
| import Muse.UiComponents 1.0 | ||
| import MuseScore.NotationScene 1.0 | ||
|
|
||
| ListItemBlank { |
There was a problem hiding this comment.
Some of the accessibility/navigation stuff from StyledMenuItem would need to be ported over as well
| Layout.fillWidth: true | ||
| horizontalAlignment: Text.AlignLeft | ||
|
|
||
| text: modelData.title |
There was a problem hiding this comment.
With https://mu--se.slack.com/archives/C013WRMQ5M5/p1734490004476809?thread_ts=1734489990.108119&cid=C013WRMQ5M5 in mind, it's perhaps better to make modelData a required property of root, rather than using it via the "context".
This PR contains:
TieJumpPointrelated code to its own fileTieJumpPointandNotehttps://github.com/user-attachments/assets/a59055ff-bfe8-41c3-9649-bedaec01e235
StyledMenuimplementation and definitely didn't need a loader. I've recreated the popup in a more straightforward way.