Fix list of available translations in macOS/Info.plist.in #26020
Conversation
There was a problem hiding this comment.
I don't have access to a macOS device right now, so I can't test the changes to Info.plist.in. I'm not sure what it does. Possibly it displays these languages somewhere in System Preferences, as a way to override the language for a particular application?
I've tried to find out what this CFBundleLocalizations key is used for, and can't find much. It seems it's mainly used for apps in the App Store, to display what languages they support. But I don't think it influences any functionality.
So it's possibly not relevant to MuseScore since we don't use the App Store, but we're not 100% certain.
| <string>bg</string> | ||
| <string>br</string> | ||
| <string>ca</string> | ||
| <string>ca@Valencia</string> |
There was a problem hiding this comment.
I'm not sure whether this a valid language code or just a Transifex-specific extention?
I guess we can keep it for now and someone on macOS can test it for us.
There was a problem hiding this comment.
I've tried to find out what this CFBundleLocalizations key is used for, and can't find much. It seems it's mainly used for apps in the App Store, to display what languages they support. But I don't think it influences any functionality.
There was a problem hiding this comment.
Makes all this more of a cosmetic change, as we don't use the App Strore, right?
There was a problem hiding this comment.
It seems so, yes. And I'd rather have an up-to-date list with perhaps a few invalid entries than a completely outdated list with potentially also some invalid entries.
There was a problem hiding this comment.
IOW: a cosmetic change worth doing, right?
| <string>cs</string> | ||
| <string>cy</string> | ||
| <string>da</string> | ||
| <string>de</string> | ||
| <string>el</string> | ||
| <string>en</string> |
There was a problem hiding this comment.
Note that you also include en_US and en_GB below. Again, someone on macOS should test this.
| <string>sv</string> | ||
| <string>th</string> | ||
| <string>tr</string> | ||
| <string>uk</string> | ||
| <string>uz@Latn</string> |
There was a problem hiding this comment.
Another fancy one that should be tested.
| <string>ar</string> | ||
| <string>ar_DZ</string> |
There was a problem hiding this comment.
This is a valid language code, but Apple might want it all lowercase or separated with a hyphen instead of an underscore. Someone with access to a Mac should test it for us.
And create a Readme.md in share/locale
Jojo-Schmitz
force-pushed
the
translations
branch
from
f6b4fe5 to
bfaf101
Compare
|
@cbjeukendrup, I'm happy with the README. I'll let you merge if you're satisfied with |
shoogle
changed the title
|
I've checked that this build runs well and doesn't show any strange behaviour w.r.t. translations on first sight, so I feel confident enough to merge this. |
And create a Readme.md in share/locale