Skip to content

Commit

Permalink
fixed playback of Let Ring + Guitar bend combination
Browse files Browse the repository at this point in the history
  • Loading branch information
RomanPudashkin committed Jan 9, 2025
1 parent b89e680 commit 7215a61
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/engraving/playback/renderers/bendsrenderer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ RenderingContext BendsRenderer::buildRenderingContext(const Note* note, const Re
}

RenderingContext ctx = engraving::buildRenderingCtx(chord, initialCtx.positionTickOffset,
initialCtx.profile, initialCtx.playbackCtx);
initialCtx.profile, initialCtx.playbackCtx,
initialCtx.commonArticulations);

if (note->isGrace()) {
GraceNotesMetaParser::parse(note->chord(), ctx, ctx.commonArticulations);
Expand Down
5 changes: 3 additions & 2 deletions src/engraving/playback/renderingcontext.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ struct RenderingContext {
};

inline RenderingContext buildRenderingCtx(const Chord* chord, const int tickPositionOffset,
const muse::mpe::ArticulationsProfilePtr profile, const PlaybackContextPtr playbackCtx)
const muse::mpe::ArticulationsProfilePtr profile, const PlaybackContextPtr playbackCtx,
const muse::mpe::ArticulationMap& articulations = {})
{
int chordPosTick = chord->tick().ticks();
int chordDurationTicks = chord->actualTicks().ticks();
Expand All @@ -118,7 +119,7 @@ inline RenderingContext buildRenderingCtx(const Chord* chord, const int tickPosi
bps,
timeSignatureFraction,
playbackCtx->persistentArticulationType(chordPosTickWithOffset),
{},
articulations,
score,
profile,
playbackCtx);
Expand Down

0 comments on commit 7215a61

Please sign in to comment.