Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute URLs in @require statements #581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use absolute URLs in @require statements #581

wants to merge 2 commits into from

Conversation

zas
Copy link
Collaborator

@zas zas commented Oct 17, 2024

  • relative links do not always work (we had multiple reports about this)

See #542 and #579

- relative links do not always work (we had multiple reports about this)
Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, using absolute URLs breaks installations from branches other than master and for forks, so I am generally not a fan of that.
I think such issues are bugs of the userscript extensions which should be fixed there, on the other hand we got multiple such reports for different userscript extensions already (#524 has been fixed in VM), so it may be worth it 🤷

P.S. Sorry for the merge conflict, I can fix that once/if we decide to merge this PR.

@zas
Copy link
Collaborator Author

zas commented Oct 17, 2024

Hmm, using absolute URLs breaks installations from branches other than master and for forks, so I am generally not a fan of that.

Yes, I agree with that too.
But we had issues in the past and they continue, and scripts break everytime :(

Not really happy with this PR either :( but not sure what to do.

bandcamp_importer.user.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants