Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandcamp: Correctly split "artist - title" #446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bandcamp: Correctly split "artist - title" #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6205ab
bandcamp_importer: Fix ESLint errors and bump version
kellnerd Dec 3, 2021
1bfdf8a
bandcamp_importer: Correctly split "artist - title"
kellnerd Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions bandcamp_importer.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// ==UserScript==
// @name Import Bandcamp releases to MusicBrainz
// @description Add a button on Bandcamp's album pages to open MusicBrainz release editor with pre-filled data for the selected release
// @version 2021.10.17.1
// @version 2021.12.3.1
// @namespace http://userscripts.org/users/22504
// @downloadURL https://raw.github.com/murdos/musicbrainz-userscripts/master/bandcamp_importer.user.js
// @updateURL https://raw.github.com/murdos/musicbrainz-userscripts/master/bandcamp_importer.user.js
Expand All @@ -20,13 +20,14 @@
// prevent JQuery conflicts, see http://wiki.greasespot.net/@grant
this.$ = this.jQuery = jQuery.noConflict(true);

// eslint-disable-next-line no-global-assign
if (!unsafeWindow) unsafeWindow = window;

String.prototype.fix_bandcamp_url = function () {
return this.replace('http://', 'https://');
};

var BandcampImport = {
const BandcampImport = {
// Analyze Bandcamp data and return a release object
retrieveReleaseInfo: function () {
let bandcampAlbumData = unsafeWindow.TralbumData;
Expand Down Expand Up @@ -94,7 +95,7 @@ var BandcampImport = {
// only set to true if ALL tracks are formatted like this
// and if string doesn't start with a number (ie. 02 - title)
let various_artists = true;
for (var i = 0; i < bandcampAlbumData.trackinfo.length; i++) {
for (let i = 0; i < bandcampAlbumData.trackinfo.length; i++) {
if (!bandcampAlbumData.trackinfo[i].title.match(/ - /) || bandcampAlbumData.trackinfo[i].title.match(/^\d+ - /)) {
various_artists = false;
break;
Expand All @@ -113,7 +114,7 @@ var BandcampImport = {
let title = bctrack.title;
let artist = [];
if (various_artists) {
let m = bctrack.title.match(/^(.+) - (.+)$/);
let m = bctrack.title.match(/^(.+?) - (.+)$/);
if (m) {
title = m[2];
artist = [m[1]];
Expand All @@ -140,12 +141,11 @@ var BandcampImport = {
if (numtracks > 0 && numtracks > showntracks) {
// display a warning if tracks in download differs from tracks shown
$('h2.trackTitle').append(
`${'<p style="font-size:70%; font-style: italic; margin: 0.1em 0;">' + 'Warning: '}${numtracks} vs ${showntracks} tracks` +
`</p>`
`<p style="font-size:70%; font-style: italic; margin: 0.1em 0;">Warning: ${numtracks} vs ${showntracks} tracks</p>`
);

// append unknown tracks to the release
for (var i = 0; i < numtracks - showntracks; i++) {
for (let i = 0; i < numtracks - showntracks; i++) {
let track = {
title: '[unknown]',
duration: null,
Expand Down Expand Up @@ -306,7 +306,7 @@ $(document).ready(function () {
let release = BandcampImport.retrieveReleaseInfo();

// add MB artist link
let root_url = release.url.match(/^(https?:\/\/[^\/]+)/)[1].split('?')[0];
let root_url = release.url.match(/^(https?:\/\/[^/]+)/)[1].split('?')[0];
let label_url = '';

mblinks.searchAndDisplayMbLink(
Expand All @@ -322,7 +322,7 @@ $(document).ready(function () {
let labelbacklink = labelback.attr('href');
if (labelbacklink) {
label_url = labelbacklink
.match(/^(https?:\/\/[^\/]+)/)[1]
.match(/^(https?:\/\/[^/]+)/)[1]
.split('?')[0]
.fix_bandcamp_url();
mblinks.searchAndDisplayMbLink(
Expand Down