core_interface.c: Don't force macOS app bundle path #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the macOS app bundle path takes precedence over
--corelibspecified via command line. This technically prevents any CLI launcher that resides in an.appdirectory from loading the core file if that file is part of a non-standard directory and/or has its file name changed (e.g.mupen64plus.dylibinstead oflibmupen64plus.dylib).This PR makes it so
core_interfacechecks for a successful path first instead of simply overriding it, if macOS is detected.I'm not entirely sure if this change is ultimately for the better, so I'm open for suggestions.