Skip to content
This repository has been archived by the owner on Jan 20, 2025. It is now read-only.

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Markus Neteler <[email protected]>
  • Loading branch information
mmacata and neteler authored Oct 30, 2024
1 parent 2117cc9 commit 2ea361f
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 11 deletions.
6 changes: 4 additions & 2 deletions r.slopeunits.clean/r.slopeunits.clean.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<h2>DESCRIPTION</h2>
<em>r.slopeunits.clean</em> cleans slope units layer, e.g. results of r.slopeunits.create.
<em>r.slopeunits.clean</em> cleans slope units layer, e.g. results of <em>r.slopeunits.create</em>.

<h2>NOTES</h2>

Expand All @@ -23,4 +23,6 @@ <h2>SEE ALSO</h2>
</em>

<h2>AUTHORS</h2>
Ivan Marchesini, Massimiliano Alvioli, Markus Metz (Refactoring, Translation of clean_method_3 to python), Carmen Tawalika (Make extra addon), <a href="https://www.mundialis.de/">mundialis</a>
Main authors: Ivan Marchesini, Massimiliano Alvioli, CNR-IRPI
<br>
Markus Metz (refactoring, translation of "clean_method_3" to python), Carmen Tawalika (creation of extra addon), <a href="https://www.mundialis.de/">mundialis</a>
2 changes: 1 addition & 1 deletion r.slopeunits.clean/r.slopeunits.clean.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# MODULE: r.slopeunits.clean for GRASS 8
# AUTHOR(S): Ivan Marchesini, Massimiliano Alvioli, Markus Metz
# (Refactoring, partly translation to python), Carmen Tawalika
# (Make extra addon)
# (creation of extra addon)
# PURPOSE: Clean slope units layer
# COPYRIGHT: (C) 2004-2024 by the GRASS Development Team
#
Expand Down
4 changes: 3 additions & 1 deletion r.slopeunits.create/r.slopeunits.create.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,6 @@ <h2>SEE ALSO</h2>
</em>

<h2>AUTHORS</h2>
Ivan Marchesini, Massimiliano Alvioli, Markus Metz (Refactoring), <a href="https://www.mundialis.de/">mundialis</a>
Main authors: Ivan Marchesini, Massimiliano Alvioli, CNR-IRPI
<br>
Markus Metz (refactoring), <a href="https://www.mundialis.de/">mundialis</a>
9 changes: 7 additions & 2 deletions r.slopeunits.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@

<h2>NAME</h2>

<em>r.slopeunits</em> is a GRASS GIS addon toolset that creates, cleans and calculate metrics for slope units. Additionally optimal input values can be determined.
<em>r.slopeunits</em> is a GRASS GIS addon toolset that creates, cleans
and calculate metrics for slope units. Additionally, optimal input values can
be determined.

<h2>KEYWORDS</h2>

Expand All @@ -31,4 +33,7 @@ <h2>DESCRIPTION</h2>
</ul>

<h2>AUTHORS</h2>
Ivan Marchesini, Massimiliano Alvioli, Markus Metz (Translation to python, Refactoring), Carmen Tawalika (Translation to python, Refactoring), <a href="https://www.mundialis.de/">mundialis</a>
Main authors: Ivan Marchesini, Massimiliano Alvioli, CNR-IRPI
<br>
Markus Metz (translation to python, refactoring), Carmen Tawalika (translation to python, refactoring),
<a href="https://www.mundialis.de/">mundialis</a>
7 changes: 5 additions & 2 deletions r.slopeunits.metrics/r.slopeunits.metrics.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<h2>DESCRIPTION</h2>
<em>r.slopeunits.metrics</em> creates metrics for slope units. Returns output "areamin, cvmin, v_fin and i_fin" to stdout, optionally writes to a file.
<em>r.slopeunits.metrics</em> creates metrics for slope units. Returns
output "areamin, cvmin, v_fin and i_fin" to stdout, optionally writes to a file.

<h2>NOTES</h2>

Expand All @@ -25,4 +26,6 @@ <h2>SEE ALSO</h2>
</em>

<h2>AUTHORS</h2>
Ivan Marchesini, Massimiliano Alvioli, Carmen Tawalika (Translation to python), <a href="https://www.mundialis.de/">mundialis</a>
Main authors: Ivan Marchesini, Massimiliano Alvioli, CNR-IRPI
<br>
Carmen Tawalika (translation to python), <a href="https://www.mundialis.de/">mundialis</a>
11 changes: 8 additions & 3 deletions r.slopeunits.optimize/r.slopeunits.optimize.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ <h2>DESCRIPTION</h2>
"cvmin" - Minimum value of the circular variance (0.0-1.0) below which the slope unit is not further segmented
</li>
</ul>
It calls r.slopeunits.create, r.slopeunits.clean and r.slopeunits.metrics iteratively.
Output is a file "opt.txt" with optimal values in either specified folder or in folder "output" in current working directory. Also files "calcd.dat" and "current.txt" are created with all determined and examined values and the four latest examined values (combination of areamin and cvmin minimum and maximum) and center respectively.
It calls <em>r.slopeunits.create</em>, <em>r.slopeunits.clean</em> and <em>r.slopeunits.metrics</em> iteratively.
Output is a file <tt>opt.txt</tt> with optimal values in either specified folder or in folder <tt>output/</tt>"
in the current working directory. Also files <tt>calcd.dat</tt> and <tt>current.txt</tt> are created with
all determined and examined values and the four latest examined values (combination of <tt>areamin<tt>
and <tt>cvmin<tt> minimum and maximum) and <tt>center</tt> respectively.

<h2>NOTES</h2>

Expand All @@ -34,4 +37,6 @@ <h2>SEE ALSO</h2>
</em>

<h2>AUTHORS</h2>
Ivan Marchesini, Massimiliano Alvioli, Carmen Tawalika (Translation to python, Refactoring), <a href="https://www.mundialis.de/">mundialis</a>
Main authors: Ivan Marchesini, Massimiliano Alvioli, CNR-IRPI
<br>
Carmen Tawalika (translation to python, refactoring), <a href="https://www.mundialis.de/">mundialis</a>

0 comments on commit 2ea361f

Please sign in to comment.