Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COCO-36: Add connectivity semantic terms on Core Connectors #521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@

<muleSocketsConnectorVersion>1.2.1</muleSocketsConnectorVersion>
<muleCorsKernelVersion>1.1.2</muleCorsKernelVersion>

<muleSdkApiVersion>0.3.0</muleSdkApiVersion>

<!-- This dependencies must be explicitly defined as long as HTTP supports runtimes prior to 4.1.2 -->
<muleHttpPolicyApiVersion>1.1.3</muleHttpPolicyApiVersion>
<mulePolicyApiVersion>1.1.3</mulePolicyApiVersion>
Expand Down Expand Up @@ -180,6 +181,11 @@
<version>${mulePolicyApiVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.mule.sdk</groupId>
<artifactId>mule-sdk-api</artifactId>
<version>${muleSdkApiVersion}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<artifactId>mule-module-http-policy-api</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@
import org.mule.runtime.http.api.server.HttpServerConfiguration;
import org.mule.runtime.http.api.server.ServerAddress;
import org.mule.runtime.http.api.server.ServerCreationException;
import org.mule.sdk.api.annotation.semantics.connectivity.ExcludeFromConnectivitySchema;
import org.mule.sdk.api.annotation.semantics.connectivity.Host;
import org.mule.sdk.api.annotation.semantics.connectivity.Port;

import java.io.IOException;
import java.lang.reflect.Field;
Expand Down Expand Up @@ -76,6 +79,7 @@ public static final class ConnectionParams {
@Example("0.0.0.0")
@Expression(NOT_SUPPORTED)
@Placement(order = 2)
@Host
private String host;

/**
Expand All @@ -85,6 +89,7 @@ public static final class ConnectionParams {
@Example("8081")
@Expression(NOT_SUPPORTED)
@Placement(order = 3)
@Port
private Integer port;

/**
Expand All @@ -94,6 +99,7 @@ public static final class ConnectionParams {
@Optional(defaultValue = "true")
@Expression(NOT_SUPPORTED)
@Placement(tab = ADVANCED, order = 1)
@ExcludeFromConnectivitySchema
private boolean usePersistentConnections;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
import org.mule.runtime.extension.api.annotation.param.display.Placement;
import org.mule.runtime.extension.api.annotation.param.display.Summary;
import org.mule.runtime.http.api.HttpConstants;
import org.mule.sdk.api.annotation.semantics.connectivity.ExcludeFromConnectivitySchema;
import org.mule.sdk.api.annotation.semantics.connectivity.Host;
import org.mule.sdk.api.annotation.semantics.connectivity.Port;

/**
* Groups parameters related to a requester connection
Expand Down Expand Up @@ -48,6 +51,7 @@ public final class RequestConnectionParams {
@Optional
@Example("www.mulesoft.com")
@Placement(order = 2)
@Host
private String host;

/**
Expand All @@ -57,6 +61,7 @@ public final class RequestConnectionParams {
@Parameter
@Optional
@Placement(order = 3)
@Port
private Integer port;

/**
Expand All @@ -66,6 +71,7 @@ public final class RequestConnectionParams {
@Optional(defaultValue = "true")
@Expression(NOT_SUPPORTED)
@Placement(tab = ADVANCED_TAB, order = 1)
@ExcludeFromConnectivitySchema
private boolean usePersistentConnections;

/**
Expand All @@ -76,6 +82,7 @@ public final class RequestConnectionParams {
@Optional(defaultValue = DEFAULT_MAX_CONNECTIONS)
@Expression(NOT_SUPPORTED)
@Placement(tab = ADVANCED_TAB, order = 2)
@ExcludeFromConnectivitySchema
private Integer maxConnections;

/**
Expand All @@ -97,6 +104,7 @@ public final class RequestConnectionParams {
@Optional(defaultValue = "false")
@Expression(NOT_SUPPORTED)
@Placement(tab = ADVANCED_TAB, order = 4)
@ExcludeFromConnectivitySchema
private boolean streamResponse;

/**
Expand All @@ -106,13 +114,15 @@ public final class RequestConnectionParams {
@Optional(defaultValue = DEFAULT_RESPONSE_BUFFER_SIZE)
@Expression(NOT_SUPPORTED)
@Placement(tab = ADVANCED_TAB, order = 5)
@ExcludeFromConnectivitySchema
private int responseBufferSize;

@Parameter
@Optional
@NullSafe
@Expression(NOT_SUPPORTED)
@Placement(tab = ADVANCED_TAB, order = 6)
@ExcludeFromConnectivitySchema
private TcpClientSocketProperties clientSocketProperties;

public HttpConstants.Protocol getProtocol() {
Expand Down