[core] Remove redundant screenshots #44877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44877--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
remove-redundant-screenshot
branch
from
ef5d05f to
770f4dc
Compare
oliviertassinari
force-pushed
the
remove-redundant-screenshot
branch
from
770f4dc to
e0552e1
Compare
zanivan
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #44876, it seems that we can simplify the screenshots we take.
I also used the opportunity to
componentsfolder, out of simplicity and clarity for developers.Before: 1356 screenshots https://app.argos-ci.com/mui/material-ui/builds/34643/127712735
After: 1325 screenshots https://app.argos-ci.com/mui/material-ui/builds/34644/127719269