several small improvements #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were generating it for the DAG op but never used if it was empty Also use litter to dump the stage contents with a cleanup so it doesnt show empty fields Signed-off-by: Itxaka <[email protected]>
Its too heavy and always the same info (its run on init) so having it repeated time and time can get pretty bad. This makes the logs much nicer and cleaner Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Otherwise it gets reproted several times Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
Oct 4, 2024
| var errs error | ||
| for _, p := range e.conditionals { | ||
| if err := p(e.logger, stage, fs, console); err != nil { | ||
| e.logger.Warnf("(conditional) Skip '%s' stage name: %s", | ||
| err.Error(), stage.Name) | ||
| err.Error(), stageName) |
There was a problem hiding this comment.
This diff with the actual Apply method was causing the DAG to be created properly with names generated if the stage had no name, but then on the log it will still shop as empty.
Itxaka
commented
Oct 4, 2024
| b, _ := json.Marshal(stage) | ||
| e.logger.Debugf("Stage: %s", string(b)) | ||
| litter.Config.HideZeroValues = true | ||
| e.logger.Debugf("Stage: %s", litter.Sdump(stage)) |
There was a problem hiding this comment.
this dumps the actual stages in a much more nicer way. It shows no empty values, so only things that are gonna be run and its in a nice structured way which makes it simpler to understand visually.
Itxaka
commented
Oct 4, 2024
Itxaka
commented
Oct 4, 2024
| l.Debug(string(data)) | ||
| litter.Config.HideZeroValues = true | ||
| litter.Config.HidePrivateFields = true | ||
| l.Trace(litter.Sdump(&system)) |
There was a problem hiding this comment.
same as the other but put this on trace level. We dont usually need this as part of the debug part and its very ugly,big and pollutes the log with a lot of useless, repeated info.
Itxaka
commented
Oct 4, 2024
Co-authored-by: Ettore Di Giacinto <[email protected]>
Co-authored-by: Ettore Di Giacinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits for explanation
Signed-off-by: Itxaka [email protected]