Various fixes to allow uid to be in a correct range #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the user always appears as if it doesn't exist Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to jimmykarily/entities
that referenced
this pull request
Jun 25, 2024
otherwise we may end up with id 65535 (the "nobody" user) Part of: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]>
mudler
pushed a commit
to mudler/entities
that referenced
this pull request
Jun 25, 2024
* Generate a user id in the range of human users otherwise we may end up with id 65535 (the "nobody" user) Part of: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]> * Update pkg/entities/user.go Signed-off-by: Dimitris Karakasilis <[email protected]> * Move magic number to constants Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
dk-fix-uid
branch
3 times, most recently
from
0199e94 to
f95d64b
Compare
jimmykarily
commented
Jun 26, 2024
| if u.PrimaryGroup != "" { | ||
| gr, err := osuser.LookupGroup(u.PrimaryGroup) | ||
| if err != nil { | ||
| return errors.Wrap(err, "could not resolve primary group of user") | ||
| } | ||
| gid, _ = strconv.Atoi(gr.Gid) | ||
| primaryGroup = u.PrimaryGroup | ||
| } else { |
There was a problem hiding this comment.
not need anymore. That's what the updateGroup.Apply will do if the gid is -1.
jimmykarily
commented
Jun 26, 2024
|
|
||
| uid := 1000 | ||
| // reload the group to get the generated GID |
There was a problem hiding this comment.
This wouldn't be needed if the ParseGroup had a pointer receiver. I don't want to change that here though to avoid breaking other things. We can consider changing it in the future to avoid this second parsing of groups.
and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Jun 26, 2024
| @@ -205,11 +210,11 @@ func User(l logger.Interface, s schema.Stage, fs vfs.FS, console Console) error | |||
| for _, k := range users { | |||
| r := s.Users[k] | |||
| r.Name = k | |||
| if !s.Users[k].Exists() { | |||
There was a problem hiding this comment.
Exists() was never true because the Name on the s.Users[k] wasn't set. It's set on r above though.
mauromorales
approved these changes
Jun 26, 2024
Itxaka
approved these changes
Jun 26, 2024
jimmykarily
added a commit
to kairos-io/immucore
that referenced
this pull request
Jun 26, 2024
to properly set kairos uid and gid in the range of human users Relevant: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/kairos-agent
that referenced
this pull request
Jun 26, 2024
to properly set kairos uid and gid in the range of human users Relevant: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]>
This was referenced Jun 26, 2024
jimmykarily
added a commit
to kairos-io/immucore
that referenced
this pull request
Jun 26, 2024
to properly set kairos uid and gid in the range of human users Relevant: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/packages
that referenced
this pull request
Jun 26, 2024
to get the yip fix for the user id an gid Relevant: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/packages
that referenced
this pull request
Jun 27, 2024
to get the yip fix for the user id an gid Relevant: mudler/yip#159 Signed-off-by: Dimitris Karakasilis <[email protected]>
davidcassany
pushed a commit
to davidcassany/yip
that referenced
this pull request
Jul 3, 2024
* Use variable that has "Name" assigned otherwise the user always appears as if it doesn't exist Signed-off-by: Dimitris Karakasilis <[email protected]> * Bump entities and xpasswd and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]> (cherry picked from commit d76f75c)
davidcassany
pushed a commit
to rancher/yip
that referenced
this pull request
Jul 8, 2024
* Use variable that has "Name" assigned otherwise the user always appears as if it doesn't exist Signed-off-by: Dimitris Karakasilis <[email protected]> * Bump entities and xpasswd and let them automatically set the uid and gid inside the "human" users range. Relevant: - mauromorales/xpasswd#3 - mudler/entities#15 Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]> (cherry picked from commit d76f75c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://systemd.io/UIDS-GIDS/#special-distribution-uid-ranges
Relevant: mauromorales/xpasswd#3