fix(isNodeProcess): avoid undefined error

[jameslahm]

Hi, Thanks for the amazing tool. I try to use it in a browser, but global is not defined came out. I think it maybe caused by isNodeProcess function. Change it to typeof process ==='object' may solve this problem.

[kettanaito]

Thank you for spotting this, @jameslahm! I've had one suggestion to the changes, could you please let me know what you think about it?

[kettanaito]

Looks awesome!

I'd love to see a unit test in a React Native environment, but to reliably bootstrap one would be an overkill in our testing pipeline. We'd have to maintain that navigator manually.

Let's wait for the CI to pass.

[jameslahm]

Yes, there should be a unit test. I add a React Native Environment test just now. Copying environment settings from React Native, and because typescript will check Process type properties, which will break the mock of global process, I add ts-nocheck. What do you think about it?

[kettanaito]

Hey. I've rebased the branch against the latest master and cleaned up the React Native test suite a little. Will wait for the CI to pass and then merge.

[kettanaito]

Great changes. Thank you, @jameslahm, and welcome to contributors!

[jameslahm]

The changes look good! Thanks!

[jameslahm]

I just found a problem, that is because we mock global.process like this Object.defineProperty(global.process, 'env', { get: () => ({ NODE_ENV: 'development', }), }), which leads Object.prototype.toString.call(global.process) still equals [object process]. It should be [object Object]? Would you mind to look at it again?