Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: msm8974: add other carrier variants of kltechn #321

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

Icenowy
Copy link

@Icenowy Icenowy commented Jan 16, 2024

The Chinese editions of Galaxy S5 (kltechn) are customized for all 3 carriers in China at that time, but currently only the Unicom one is tested and added.

Add the other two carrier editions.

Tested-by: Icenowy Zheng [email protected] # for Telecom

==================
Test for G9008 is wanted, if @xtexChooser could do this thus thanks.

The Chinese editions of Galaxy S5 (kltechn/kltechnduo) are customized
for all 3 carriers in China at that time, but currently only the Unicom
one is tested and added.

Add the other two carrier editions.

Signed-off-by: Icenowy Zheng <[email protected]>
Tested-by: Icenowy Zheng <[email protected]> # for Telecom
Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Would appreciate if you also add them to the readme list (i.e. just extend the existing line for China Unicom to say other two also work)

Because now all LTE-capable editions from China are supported.

There is a variant w/o LTE for China Telecom (codenamed k3gduosctc and
with model number SM-G9009D), which seems to be a different hardware and
not covered yet.

Signed-off-by: Icenowy Zheng <[email protected]>
Copy link
Contributor

@Rongronggg9 Rongronggg9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Disclaimer: I am the author of the original kltechn dt. My G9006W is out of reach until February so I cannot do any test now.

@xtexx
Copy link

xtexx commented Jan 26, 2024

Tested-by: Bingwu Zhang [email protected] # for Mobile

lk_log.txt

@TravMurav
Copy link
Member

Thanks!

@TravMurav TravMurav merged commit 8195380 into msm8916-mainline:master Jan 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants