Fixed #1: Problems with JSONStorage

README.rst

@@ -116,7 +116,7 @@ you should consider using a DB that is optimized for speed like Buzhug_ or
 CodernityDB_.
 
 How to Improve TinyDB Performance
-`````````````````````````````````````
+`````````````````````````````````
 
 The default storage serializes the data using JSON. To improve performance,
 you can install `ujson <http://pypi.python.org/pypi/ujson>`_ , a extremely
@@ -141,6 +141,11 @@ see `semver.org <http://semver.org/>`_
 Changelog
 ---------
 
+**v1.0.1** (2013-07-20)
+^^^^^^^^^^^^^^^^^^^^^^^
+
+- Fixed a bug in ``JSONStorage`` that broke the database when removing entries.
+
 **v1.0.0** (2013-07-20)
 ^^^^^^^^^^^^^^^^^^^^^^^
 

docs/changelog.rst

@@ -7,6 +7,12 @@ Version Numbering
 TinyDB follows the SemVer versioning guidelines. For more information,
 see `semver.org <http://semver.org/>`_
 
+**v1.0.1** (2013-07-20)
+^^^^^^^^^^^^^^^^^^^^^^^
+
+- Fixed a bug in ``JSONStorage`` that broke the database when removing entries.
+
+
 **v1.0.0** (2013-07-20)
 -----------------------
 

setup.py

@@ -3,7 +3,7 @@
 
 setup(
     name = "tinydb",
-    version = "1.0.0",
+    version = "1.0.1",
     packages = find_packages(),
 
     # development metadata

tests/tests_storages.py

@@ -5,6 +5,7 @@
 
 from nose.tools import *
 
+from tinydb import TinyDB, where
 from tinydb.storages import JSONStorage, MemoryStorage
 
 path = None
@@ -15,7 +16,7 @@
 
 
 def setup():
-    global path, element
+    global path
 
     # Generate temp file
     tmp = tempfile.NamedTemporaryFile(delete=False)
@@ -43,6 +44,32 @@ def test_json():
     assert_equal(element, storage.read())
 
 
+def test_json_readwrite():
+    # Generate temp file
+    tmp = tempfile.NamedTemporaryFile(delete=False)
+    tmp.file.close()  # Close file handle
+
+    # Create TinyDB instance
+    db = TinyDB(tmp.name, storage=JSONStorage)
+
+    item = {'name': 'A very long entry'}
+    item2 = {'name': 'A short one'}
+
+    get = lambda s: db.get(where('name') == s)
+
+    db.insert(item)
+    assert_equal(get('A very long entry'), item)
+
+    db.remove(where('name') == 'A very long entry')
+    assert_equal(get('A very long entry'), None)
+
+    db.insert(item2)
+    assert_equal(get('A short one'), item2)
+
+    db.remove(where('name') == 'A short one')
+    assert_equal(get('A short one'), None)
+
+
 def test_in_memory():
     # Write contents
     storage = MemoryStorage()

tinydb/__init__.py

@@ -59,6 +59,7 @@ def table(self, name='_default'):
         :param name: The name of the table.
         :type name: str
         """
+
         if name in self._table_cache:
             return self._table_cache[name]
 

tinydb/storages.py

@@ -77,6 +77,7 @@ def write(self, data):
         self._handle.seek(0)
         json.dump(data, self._handle)
         self._handle.flush()
+        self._handle.truncate()
 
     def read(self):
         self._handle.seek(0)