Fix open-telemetry#1661 Removed setting error status while recording …

…err as span event
mrveera · Mar 5, 2021 · 3ec3208 · 3ec3208
1 parent 7153ef2
commit 3ec3208
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,11 +11,12 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 ## Added
 
 - Added `Marshler` config option to `otlphttp` to enable otlp over json or protobufs. (#1586)
+
 ### Removed
 
 - Removed the exported `SimpleSpanProcessor` and `BatchSpanProcessor` structs.
    These are now returned as a SpanProcessor interface from their respective constructors. (#1638)
-
+- Removed setting `ErrorStatus`  while recording err as span event in `RecordError`. (#1663)
 ## [0.18.0] - 2020-03-03
 
 ### Added

diff --git a/sdk/trace/span.go b/sdk/trace/span.go
@@ -255,14 +255,14 @@ func (s *span) End(options ...trace.SpanOption) {
 	}
 }
 
-// RecordError will record err as a span event for this span. If this span is
-// not being recorded or err is nil than this method does nothing.
+// RecordError will record err as a span event for this span. This will
+// not set error status to span. If this span is not being recorded or
+// err is nil than this method does nothing.
 func (s *span) RecordError(err error, opts ...trace.EventOption) {
 	if s == nil || err == nil || !s.IsRecording() {
 		return
 	}
 
-	s.SetStatus(codes.Error, "")
 	opts = append(opts, trace.WithAttributes(
 		errorTypeKey.String(typeStr(err)),
 		errorMessageKey.String(err.Error()),

diff --git a/sdk/trace/trace_test.go b/sdk/trace/trace_test.go
@@ -1093,7 +1093,7 @@ func TestRecordError(t *testing.T) {
 			},
 			ParentSpanID:    sid,
 			Name:            "span0",
-			StatusCode:      codes.Error,
+			StatusCode:      codes.Unset,
 			SpanKind:        trace.SpanKindInternal,
 			HasRemoteParent: true,
 			MessageEvents: []trace.Event{