Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed GenerateBlockCount bug #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

vk5880
Copy link

@vk5880 vk5880 commented Jul 5, 2021

No description provided.

@mrfright
Copy link
Owner

mrfright commented Jul 8, 2021

What is the bug these fix?

@vk5880
Copy link
Author

vk5880 commented Jul 8, 2021

What is the bug these fix?

Hello,
First commit fix incorrect lines counting, used in error messages, maybe elsewhere.
Second is related to printing nacho file, there are blockfactor and block count parameters, and file must have factor*count lines by nacho specification.
Last block should be filled with line of '9' chars by specification.
Third is same fix but for parsing

@mrfright
Copy link
Owner

mrfright commented Aug 6, 2021

Do you have an example ACH file that would exhibit these errors? I'd like to write some tests to catch these errors and others, then can add your fixes and see them fix the failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants