CI: GMP not in PATH on newer MacOS

mratsim · Jan 25, 2025 · 114b6f4 · 114b6f4
1 parent c529ab6
commit 114b6f4
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -374,25 +374,32 @@ jobs:
           cd constantine
           nimble make_zkalc
 
-      - name: Run Constantine in-depth tests (Unix - with GMP, with Assembly)
-        if: runner.os != 'Windows' && matrix.target.ctt_backend == 'ASM'
+      - name: Run Constantine in-depth tests (Linux - with GMP, with Assembly)
+        if: runner.os == 'Linux' && matrix.target.ctt_backend == 'ASM'
         shell: bash
         run: |
           cd constantine
           nimble test_parallel --verbose
       - name: Run Constantine in-depth tests (Unix - with GMP, no Assembly)
-        if: runner.os != 'Windows' && matrix.target.ctt_backend == 'NO_ASM'
+        if: runner.os == 'Linux' && matrix.target.ctt_backend == 'NO_ASM'
         shell: bash
         run: |
           cd constantine
           CTT_ASM=0 nimble test_parallel --verbose
 
-      - name: Run Constantine in-depth tests (Windows - no GMP, with Assembly)
-        # So "test_bindings" uses C and can find GMP
-        # but nim-gmp cannot find GMP on Windows CI
-        # Also need to workaround asynctools not being able to create pipes https://github.com/nim-lang/Nim/issues/23118
-        # And LTO impossible constraint in the deneb_kzg test (but not MSM for some reason)
-        if: runner.os == 'Windows' && matrix.target.ctt_backend == 'ASM'
+      # On Windows
+      #   So "test_bindings" uses C and can find GMP
+      #   but nim-gmp cannot find GMP on Windows CI
+      #   Also need to workaround asynctools not being able to create pipes https://github.com/nim-lang/Nim/issues/23118
+      #   And LTO impossible constraint in the deneb_kzg test (but not MSM for some reason)
+      #
+      # On mac
+      #   Homebrew install is not in default PATH
+      #   this can be workaround with LD_LIBRARY_PATH for libraries
+      #   but headers would need a
+      #     --passC:-I$(brew --prefix)/include (-I/opt/homebrew/include on latest MacOS versions)
+      - name: Run Constantine in-depth tests (MacOS/Windows - no GMP, with Assembly)=
+        if: runner.os != 'Linux' && matrix.target.ctt_backend == 'ASM'
         shell: msys2 {0}
         run: |
           cd constantine
@@ -401,11 +408,8 @@ jobs:
           else
             nimble test_parallel_no_gmp --verbose
           fi
-      - name: Run Constantine in-depth tests (Windows - no GMP, no Assembly)
-        # So "test_bindings" uses C and can find GMP
-        # but nim-gmp cannot find GMP on Windows CI
-        # Also need to workaround asynctools not being able to create pipes https://github.com/nim-lang/Nim/issues/23118
-        if: runner.os == 'Windows' && matrix.target.ctt_backend == 'NO_ASM'
+      - name: Run Constantine in-depth tests (MacOS/Windows - no GMP, no Assembly)
+        if: runner.os != 'Linux' && matrix.target.ctt_backend == 'NO_ASM'
         shell: msys2 {0}
         run: |
           cd constantine