Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xcode versions for apple-clang builds #651

Merged

Conversation

rothmichaels
Copy link
Contributor

Since mp-units requires at least Xcode 15 we should have coverage on the latest compilers for operating system versions for macOS 13 (Ventura) and macOS 14 (Sequoia) as those are the operating systems with necessary compilers that our users would be using.

Now build with Xcode 15.2 instead of 15.0.1 which last version supported on macOS 13.

Add a build for Xcode 15.4 and Xcode 16.1 for testing macOS 14 builds. Since Xcode 16.1 is new most of our clients using macOS 14 would might more likely be using Xcode 15.4.

There might not be much C++ changes between Xcode 15.2 and Xcode 15.4 so perhaps we should drop 15.4 if adding three apple-clang builds is not worth the resources.

@rothmichaels
Copy link
Contributor Author

@mpusz Let me know what you think and if we should drop 15.4 from the matrix — not sure what resources are costing us for adding to the test matrix.

@rothmichaels rothmichaels force-pushed the feature/update-apple-clang-test-matrix branch from 4cf2ff5 to a086c18 Compare November 28, 2024 15:55
@mpusz
Copy link
Owner

mpusz commented Nov 28, 2024

I do not know what are the differences between 15.2 and 15.4. Are there any significant apple-clang version changes?

Also, could you please check if any of the new versions support additional features from https://mpusz.github.io/mp-units/latest/getting_started/cpp_compiler_support?

@rothmichaels
Copy link
Contributor Author

I do not know what are the differences between 15.2 and 15.4. Are there any significant apple-clang version changes?

I don't think a lot (the performance bugs exist in both). There were some apple-clang updates in 15.3 that you can see here https://developer.apple.com/documentation/xcode-release-notes/xcode-15_3-release-notes

I think all of Xcode 15 is based on some fork of clang/llvm 16.

Also, could you please check if any of the new versions support additional features from https://mpusz.github.io/mp-units/latest/getting_started/cpp_compiler_support?

I think maybe there is some std::format support? I can try that out tomorrow.

@mpusz
Copy link
Owner

mpusz commented Dec 9, 2024

According to my knowledge from mainstream clang versions, std::format support was added in clang-17. If 15.4 is still based on clang-16 then we probably do not have to test it.

For sure we need to build on the latest macOS 13 version (15.2) to not drop our users. And of course we need to test Xcode 16 from macOS 14.

Since mp-units requires at least Xcode 15 we should have coverage on the
latest compilers for operating system versions for macOS 13 (Ventura)
and macOS 14 (Sequoia) as those are the operating systems with necessary
compilers that our users would be using.

Now build with Xcode 15.2 instead of 15.0.1 which last version supported
on macOS 13.

Add a build for Xcode 15.4 and Xcode 16.1 for testing macOS 14 builds.
Since Xcode 16.1 is new most of our clients using macOS 14 would might
more likely be using Xcode 15.4.

There might not be much C++ changes between Xcode 15.2 and Xcode 15.4 so
perhaps we should drop 15.4 if adding three apple-clang builds is not
worth the resources.
@rothmichaels rothmichaels force-pushed the feature/update-apple-clang-test-matrix branch from e5f9626 to b70ded5 Compare December 19, 2024 17:18
Copy link
Owner

@mpusz mpusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpusz mpusz merged commit d9c3911 into mpusz:master Dec 19, 2024
81 checks passed
@rothmichaels rothmichaels deleted the feature/update-apple-clang-test-matrix branch December 19, 2024 17:54
@rothmichaels rothmichaels restored the feature/update-apple-clang-test-matrix branch December 19, 2024 19:08
@rothmichaels rothmichaels deleted the feature/update-apple-clang-test-matrix branch December 19, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants