-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Xcode versions for apple-clang builds #651
Update Xcode versions for apple-clang builds #651
Conversation
@mpusz Let me know what you think and if we should drop 15.4 from the matrix — not sure what resources are costing us for adding to the test matrix. |
4cf2ff5
to
a086c18
Compare
I do not know what are the differences between 15.2 and 15.4. Are there any significant apple-clang version changes? Also, could you please check if any of the new versions support additional features from https://mpusz.github.io/mp-units/latest/getting_started/cpp_compiler_support? |
I don't think a lot (the performance bugs exist in both). There were some apple-clang updates in 15.3 that you can see here https://developer.apple.com/documentation/xcode-release-notes/xcode-15_3-release-notes I think all of Xcode 15 is based on some fork of clang/llvm 16.
I think maybe there is some |
According to my knowledge from mainstream clang versions, For sure we need to build on the latest macOS 13 version (15.2) to not drop our users. And of course we need to test Xcode 16 from macOS 14. |
Since mp-units requires at least Xcode 15 we should have coverage on the latest compilers for operating system versions for macOS 13 (Ventura) and macOS 14 (Sequoia) as those are the operating systems with necessary compilers that our users would be using. Now build with Xcode 15.2 instead of 15.0.1 which last version supported on macOS 13. Add a build for Xcode 15.4 and Xcode 16.1 for testing macOS 14 builds. Since Xcode 16.1 is new most of our clients using macOS 14 would might more likely be using Xcode 15.4. There might not be much C++ changes between Xcode 15.2 and Xcode 15.4 so perhaps we should drop 15.4 if adding three apple-clang builds is not worth the resources.
e5f9626
to
b70ded5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Since mp-units requires at least Xcode 15 we should have coverage on the latest compilers for operating system versions for macOS 13 (Ventura) and macOS 14 (Sequoia) as those are the operating systems with necessary compilers that our users would be using.
Now build with Xcode 15.2 instead of 15.0.1 which last version supported on macOS 13.
Add a build for Xcode 15.4 and Xcode 16.1 for testing macOS 14 builds. Since Xcode 16.1 is new most of our clients using macOS 14 would might more likely be using Xcode 15.4.
There might not be much C++ changes between Xcode 15.2 and Xcode 15.4 so perhaps we should drop 15.4 if adding three apple-clang builds is not worth the resources.