Move entry-point main methods to separate package #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you just make sure you new files have the copyright/license header at the top? Other than that change looks good. |
|
Repushed with added copyright headers (squashed all changes into one commit). |
mpetazzoni
added a commit
that referenced
this pull request
Aug 26, 2013
Move entry-point main methods to separate package Signed-off-by: Maxime Petazzoni <[email protected]>
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ttorrent as a library, I ran into a couple annoying visibility issues. By moving the entry-point main methods of the codebase into classes of a separate package we get the benefit of:
Enforcing 3rd-party code using ttorrent as a library has the same privileges as command-line entry-points.
Uncluttering some key classes making them easier to scan and comprehend.
The moved method bodies and javadoc are kept as identical as possible, with only two non-move changes to make it possible: (a) Adding the Tracker#getTrackedTorrents() getter, and (b) making Client.ClientShutdown public.
This pull request will conflict with https://github.com/turn/ttorrent/pull/58 due to both having the new getTrackedTorrents() getter, but I will happily update whichever pull request goes second.