Bug 1408100 - Upgrade to Bootstrap 4 #2823
Conversation
package.json
Outdated
| "react": "15.3.2", | ||
| "react-dom": "15.3.2", | ||
| "taskcluster-client": "2.5.0" | ||
| "react": "^15.4.2", |
There was a problem hiding this comment.
Don't forget to remove these react changes and other package updates from this PR :-)
camd
force-pushed
the
bootstrap-4
branch
4 times, most recently
from
593a22a to
5e8d68f
Compare
|
Have you tested that Perfherder still works with the updated dependency? I'm kind of suspecting that there might be significant issues. :/ |
|
@wlach : Yeah. I'm still in progress on this. But the short answer is: Yes, I've been testing it as I made changes. But not done with all the changes yet... One of the big things is that I need to remove dependency on So, yeah, this will heavily affect Perfherder. I'm testing it as best I can as I go. But I was also hoping to hit you up later this week to perhaps help a bit with running through some scenarios. This has been a long process since it largely affects almost EVERY part of our UI. Quite a slog, but I think it will open doors for us long-term. |
|
Ok good to know. Some parts of perfherder use angular-ui-bootstrap rather extensively (I think moreso than treeherder, actually) so was a bit worried about that angle in particular. Feel free to hit me up anytime if you want to discuss further, I'll be around. |
|
Closing this one as I took a different tack in another branch in PR #2883 |
No description provided.