Backend changes for change culprit revision

mozilla · Dec 3, 2024 · 12db15b · 12db15b
1 parent eb231e9
commit 12db15b
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/tests/webapp/api/test_performance_alertsummary_api.py b/tests/webapp/api/test_performance_alertsummary_api.py
@@ -88,6 +88,7 @@ def test_alert_summaries_get(
         "related_alerts",
         "repository",
         "push_id",
+        "original_revision",
         "status",
         "revision",
         "push_timestamp",
@@ -167,6 +168,7 @@ def test_alert_summaries_get_onhold(
         "related_alerts",
         "repository",
         "push_id",
+        "original_revision",
         "status",
         "revision",
         "push_timestamp",
@@ -238,6 +240,37 @@ def test_alert_summaries_put(
     assert PerformanceAlertSummary.objects.get(id=1).assignee == test_user
 
 
+def test_performance_alert_summary_change_revision(
+    client, test_perf_alert_summary, test_sheriff, test_push
+):
+    client.force_authenticate(user=test_sheriff)
+
+    # verify we can set revision
+    assert PerformanceAlertSummary.objects.get(id=1).push.revision != test_push.revision
+    resp = client.put(
+        reverse("performance-alert-summaries-list") + "1/",
+        {"revision": test_push.revision},
+    )
+    assert resp.status_code == 200
+    assert PerformanceAlertSummary.objects.get(id=1).push.revision == test_push.revision
+
+    # verify we can set non-existing revision
+    resp = client.put(
+        reverse("performance-alert-summaries-list") + "1/",
+        {"revision": "no-push-revision"},
+    )
+    assert resp.status_code == 400
+
+    # revert revision
+    original_revision = PerformanceAlertSummary.objects.get(id=1).original_push.revision
+    resp = client.put(
+        reverse("performance-alert-summaries-list") + "1/",
+        {"revision": original_revision},
+    )
+    assert resp.status_code == 200
+    assert PerformanceAlertSummary.objects.get(id=1).push.revision == original_revision
+
+
 def test_auth_for_alert_summary_post(
     client,
     test_repository,

diff --git a/treeherder/webapp/api/performance_serializers.py b/treeherder/webapp/api/performance_serializers.py
@@ -17,6 +17,7 @@
     PerformanceFramework,
     PerformanceSignature,
     PerformanceTag,
+    Push,
 )
 from treeherder.webapp.api.utils import to_timestamp, FIVE_DAYS
 
@@ -272,7 +273,8 @@ class PerformanceAlertSummarySerializer(serializers.ModelSerializer):
     )
     repository = serializers.SlugRelatedField(read_only=True, slug_field="name")
     framework = serializers.SlugRelatedField(read_only=True, slug_field="id")
-    revision = serializers.SlugRelatedField(read_only=True, slug_field="revision", source="push")
+    revision = serializers.SlugRelatedField(read_only=False, slug_field="revision", source="push", required=False, queryset=Push.objects.all())
+    original_revision = serializers.SlugRelatedField(read_only=True, slug_field="revision", source="original_push")
     push_timestamp = TimestampField(source="push", read_only=True)
     prev_push_revision = serializers.SlugRelatedField(
         read_only=True, slug_field="revision", source="prev_push"
@@ -308,6 +310,7 @@ class Meta:
             "id",
             "push_id",
             "prev_push_id",
+            "original_revision",
             "created",
             "first_triaged",
             "triage_due_date",