Implement number classes using lambdas #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # rhino/src/main/java/org/mozilla/javascript/LambdaConstructor.java
rbri
reviewed
Feb 3, 2025
| @@ -1076,7 +1076,8 @@ public static String toString(double val) { | |||
|
|
|||
| public static String numberToString(double d, int base) { | |||
| if ((base < 2) || (base > 36)) { | |||
| throw Context.reportRuntimeErrorById("msg.bad.radix", Integer.toString(base)); | |||
| // throw Context.reportRuntimeErrorById("msg.bad.radix", Integer.toString(base)); | |||
There was a problem hiding this comment.
i think we can remove the throw (at lease if there is somewhere a test for that)
There was a problem hiding this comment.
Looks like a miss in my editing or merging -- this should just throw a range error. Thanks!
|
yes please .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step in the push to move away from IdScriptableObject is to switch the implementations of Number, BigInteger, and Boolean to be based on lambdas.