-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise NotFoundError if no daily build can be found for latest build date #672
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c9d776c
Add Fenix daily platform handling (#664)
piri-p bf7ca93
Merge branch 'master' into issue-664-fenix-platform-daily
whimboo 40a6139
Add Fenix daily platform handling (#664) - fix error message
piri-p dc5b1bd
Add Fenix daily platform handling (#664) - add test cases
piri-p 01819e2
Add Fenix daily platform handling (#664) - switch to NotFoundError
piri-p 583f68e
Add Fenix daily platform handling (#664) - add missing url to NotFoun…
piri-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#!/usr/bin/env python | ||
|
||
# This Source Code Form is subject to the terms of the Mozilla Public | ||
# License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
# You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
||
import pytest | ||
|
||
from mozdownload import DailyScraper | ||
import mozdownload.errors as errors | ||
|
||
@pytest.mark.parametrize('args', [ | ||
({'application': 'fenix', 'platform': 'mac'}), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please note that with the follow-up PR for |
||
]) | ||
def test_invalid_platform(httpd, tmpdir, args): | ||
"""Testing download scenarios with invalid platform parameters for DailyScraper""" | ||
|
||
with pytest.raises(errors.NotSupportedError): | ||
DailyScraper(destination=str(tmpdir), base_url=httpd.get_url(), **args) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that this should be a
NotFoundError
. Looks like it slipped through in my last review. Can you please update both the code here and the test?Beside that we probably should indeed have a
NotSupportedError
thrown when an unsupported platform has been specified. But this check should be done as early as possible when we know the application and which kind of platform is selected. I would suggest that you create a separate PR for that and we leave open the issue even with this PR merged.