Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include prefixes_to_ignore parameter to allow ignoring specific prefixes in Keywords feature #3928

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

PromiseFru
Copy link
Collaborator

Fixes: #3926

@PromiseFru
Copy link
Collaborator Author

Click for Post PR Training
2024-01-03 10:22:30,709:INFO:__main__:Training *bugtype* model
2024-01-03 10:22:53,981:INFO:bugbug.models.bugtype:7553 crash bugs
2024-01-03 10:22:54,030:INFO:bugbug.models.bugtype:561 memory bugs
2024-01-03 10:22:54,080:INFO:bugbug.models.bugtype:4621 performance bugs
2024-01-03 10:22:54,130:INFO:bugbug.models.bugtype:125 power bugs
2024-01-03 10:22:54,180:INFO:bugbug.models.bugtype:2563 security bugs
Traceback (most recent call last):
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 145, in <module>
    main()
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 141, in main
    retriever.go(args)
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 41, in go
    metrics = model_obj.train(limit=args.limit)
  File "/home/promisefru/mozilla/bugbug/bugbug/model.py", line 377, in train
    self.le.fit(y)
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/site-packages/sklearn/preprocessing/_label.py", line 98, in fit
    y = column_or_1d(y, warn=True)
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/site-packages/sklearn/utils/validation.py", line 1156, in column_or_1d
    raise ValueError(
ValueError: y should be a 1d array, got an array of shape (198635, 5) instead.
Click for Pre PR Training
2024-01-03 10:33:05,699:INFO:__main__:Training *bugtype* model
2024-01-03 10:33:28,903:INFO:bugbug.models.bugtype:7553 crash bugs
2024-01-03 10:33:28,948:INFO:bugbug.models.bugtype:561 memory bugs
2024-01-03 10:33:28,994:INFO:bugbug.models.bugtype:4621 performance bugs
2024-01-03 10:33:29,040:INFO:bugbug.models.bugtype:125 power bugs
2024-01-03 10:33:29,087:INFO:bugbug.models.bugtype:2563 security bugs
Traceback (most recent call last):
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 145, in <module>
    main()
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 141, in main
    retriever.go(args)
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 41, in go
    metrics = model_obj.train(limit=args.limit)
  File "/home/promisefru/mozilla/bugbug/bugbug/model.py", line 377, in train
    self.le.fit(y)
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/site-packages/sklearn/preprocessing/_label.py", line 98, in fit
    y = column_or_1d(y, warn=True)
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/site-packages/sklearn/utils/validation.py", line 1156, in column_or_1d
    raise ValueError(
ValueError: y should be a 1d array, got an array of shape (198635, 5) instead.

@PromiseFru
Copy link
Collaborator Author

@suhaibmujahid, I'm wondering if the error encountered during the training of the bugtype model is something we should investigate.

Traceback (most recent call last):
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 145, in <module>
    main()
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 141, in main
    retriever.go(args)
  File "/home/promisefru/mozilla/bugbug/scripts/trainer.py", line 41, in go
    metrics = model_obj.train(limit=args.limit)
  File "/home/promisefru/mozilla/bugbug/bugbug/model.py", line 377, in train
    self.le.fit(y)
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/site-packages/sklearn/preprocessing/_label.py", line 98, in fit
    y = column_or_1d(y, warn=True)
  File "/home/promisefru/anaconda3/envs/bugbug/lib/python3.10/site-packages/sklearn/utils/validation.py", line 1156, in column_or_1d
    raise ValueError(
ValueError: y should be a 1d array, got an array of shape (198635, 5) instead.

Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@suhaibmujahid suhaibmujahid merged commit 16f868d into mozilla:master Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[model:bugtype] The Keywords feature accepts keywords but is given keyword prefixes
2 participants