Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain pre-commit to use Python 10 #3854

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Constrain pre-commit to use Python 10 #3854

merged 1 commit into from
Nov 25, 2023

Conversation

suhaibmujahid
Copy link
Member

Fixes #3853

marco-c
marco-c approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only downside is that we'll have to remember to update this whenever we bump the minimum version we support

@suhaibmujahid
Copy link
Member Author

The only downside is that we'll have to remember to update this whenever we bump the minimum version we support

I agree. I wish that we could specify a minimum version instead of penning it on a specific version. Anyway, this will make it less tricky for new contributors

@suhaibmujahid suhaibmujahid merged commit 4094c86 into mozilla:master Nov 25, 2023
6 checks passed
@suhaibmujahid suhaibmujahid deleted the pre-commit-py3.10 branch November 25, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The pre-commit linter picks the wrong Python version
2 participants
@suhaibmujahid @marco-c