Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the last redundant execution of string lowering in bug_to_types() #3850

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Fix the last redundant execution of string lowering in bug_to_types() #3850

merged 3 commits into from
Nov 24, 2023

Conversation

sreeroo
Copy link
Contributor

@sreeroo sreeroo commented Nov 24, 2023

Fixes #3845

@suhaibmujahid suhaibmujahid changed the title Optimize bug_to_types function Fix the last redundant execution of string lowering in bug_to_types() Nov 24, 2023
suhaibmujahid
suhaibmujahid approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @sreeroop10!

@suhaibmujahid suhaibmujahid merged commit fe11700 into mozilla:master Nov 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhaibmujahid suhaibmujahid suhaibmujahid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize the bug_to_types() functions to avoid redundant the execution of string lowering
2 participants
@sreeroo @suhaibmujahid