Refactor logging functions to use %s formatting instead of f-strings

bugbug/models/browsername.py

@@ -70,10 +70,10 @@ def get_labels(self):
                 classes[issue["number"]] = 0
 
         logger.info(
-            f"{sum(1 for label in classes.values() if label == 1)} issues belong to Firefox"
+            "%d issues belong to Firefox",sum(1 for label in classes.values() if label == 1)
         )
         logger.info(
-            f"{sum(1 for label in classes.values() if label == 0)} issues do not belong to Firefox"
+            "%d issues do not belong to Firefox",sum(1 for label in classes.values() if label == 0)
         )
 
         return classes, [0, 1]

bugbug/models/bugtype.py

@@ -158,7 +158,7 @@ def get_labels(self) -> tuple[dict[int, np.ndarray], list[str]]:
 
         for type_ in TYPE_LIST:
             logger.info(
-                f"{sum(1 for target in classes.values() if target[TYPE_LIST.index(type_)] == 1)} {type_} bugs"
+                "%d %s bugs",sum(1 for target in classes.values() if target[TYPE_LIST.index(type_)] == 1),type_
             )
 
         return classes, TYPE_LIST

bugbug/models/needsdiagnosis.py

@@ -81,10 +81,10 @@ def get_labels(self):
                 classes[issue["number"]] = 1
 
         logger.info(
-            f"{sum(1 for label in classes.values() if label == 1)} issues have not been moved to needsdiagnosis"
+            "%d issues have not been moved to needsdiagnosis",{sum(1 for label in classes.values() if label == 1)}
         )
         logger.info(
-            f"{sum(1 for label in classes.values() if label == 0)} issues have been moved to needsdiagnosis"
+            "%d issues have been moved to needsdiagnosis",{sum(1 for label in classes.values() if label == 0)}
         )
 
         return classes, [0, 1]

scripts/bug_retriever.py

@@ -28,7 +28,7 @@ def retrieve_bugs(self, limit: int = None) -> None:
 
         if last_modified is not None:
             logger.info(
-                f"Retrieving IDs of bugs modified since the last run on {last_modified}"
+                "Retrieving IDs of bugs modified since the last run on %s",last_modified
             )
             changed_ids = set(
                 bugzilla.get_ids(
@@ -52,7 +52,7 @@ def retrieve_bugs(self, limit: int = None) -> None:
             if "{}::{}".format(bug["product"], bug["component"]) not in all_components
         )
         logger.info(
-            f"{len(deleted_component_ids)} bugs belonging to deleted components"
+            "%d bugs belonging to deleted components",len(deleted_component_ids)
         )
         changed_ids |= deleted_component_ids
 
@@ -107,7 +107,7 @@ def retrieve_bugs(self, limit: int = None) -> None:
         if limit:
             regression_related_ids = regression_related_ids[-limit:]
         logger.info(
-            f"{len(regression_related_ids)} bugs which caused regressions fixed by commits."
+            "%d bugs which caused regressions fixed by commits.",len(regression_related_ids)
         )
 
         # Get IDs of bugs linked to intermittent failures.
@@ -152,7 +152,7 @@ def retrieve_bugs(self, limit: int = None) -> None:
                 )
             )
             logger.info(
-                f"{len(regression_related_ids)} bugs which caused regressions fixed by commits."
+                "%d bugs which caused regressions fixed by commits.",len(regression_related_ids)
             )
             if limit:
                 regression_related_ids = regression_related_ids[-limit:]
@@ -175,7 +175,7 @@ def retrieve_bugs(self, limit: int = None) -> None:
                 break
 
             logger.info(
-                f"Re-downloading {len(inconsistent_bug_ids)} bugs, as they were inconsistent"
+                "Re-downloading %d bugs, as they were inconsistent",len(inconsistent_bug_ids)
             )
             bugzilla.delete_bugs(lambda bug: bug["id"] in inconsistent_bug_ids)
             bugzilla.download_bugs(inconsistent_bug_ids)
@@ -186,7 +186,7 @@ def retrieve_bugs(self, limit: int = None) -> None:
         }
         bugzilla.delete_bugs(lambda bug: bug["id"] in missing_history_bug_ids)
         logger.info(
-            f"Deleted {len(missing_history_bug_ids)} bugs as we couldn't retrieve their history"
+            "Deleted %d bugs as we couldn't retrieve their history",len(missing_history_bug_ids)
         )
 
         zstd_compress(bugzilla.BUGS_DB)

scripts/commit_classifier.py

@@ -294,7 +294,7 @@ def apply_phab(self, hg, phabricator_deployment, diff_id):
             # Stop as soon as a base revision is available
             if self.has_revision(hg, patch.base_revision):
                 logger.info(
-                    f"Stopping at diff {patch.id} and revision {patch.base_revision}"
+                    "Stopping at diff %f and revision %f",patch.id,patch.base_revision
                 )
                 break
 
@@ -383,7 +383,7 @@ def load_user(phid):
                 message = replace_reviewers(message, reviewers)
 
             logger.info(
-                f"Applying {patch.phid} from revision {revision['id']}: {message}"
+                "Applying %f from revision {revision['id']}: %s",patch.phid,message
             )
 
             hg.import_(

scripts/github_issue_retriever.py

@@ -80,7 +80,7 @@ def retrieve_issues(self) -> None:
 
         if last_modified:
             logger.info(
-                f"Retrieving issues modified or created since the last run on {last_modified.isoformat()}"
+                "Retrieving issues modified or created since the last run on %s",last_modified.isoformat()
             )
             data = self.github.fetch_issues_updated_since_timestamp(
                 last_modified.isoformat()

scripts/maintenance_effectiveness_indicator.py

@@ -54,7 +54,7 @@ def main() -> None:
     )
 
     for factor, value in result.items():
-        logger.info(f"{factor}: {round(value, 2) if value != math.inf else value}")
+        logger.info("%s : %d",factor,round(value, 2) if value != math.inf else value)
 
 
 if __name__ == "__main__":

scripts/regressor_finder.py

@@ -340,7 +340,7 @@ def mercurial_to_git(revs):
             for bug_introducing_commit in prev_bug_introducing_commits
         )
         logger.info(
-            f"Already classified {len(prev_bug_introducing_commits)} commits..."
+            "Already classified %s commits...",len(prev_bug_introducing_commits)
         )
 
         hashes_to_ignore = set(commit["rev"] for commit in commits_to_ignore)

scripts/shadow_scheduler_stats.py

@@ -63,7 +63,7 @@ def go(months: int) -> None:
         scheduler_stat["id"] for scheduler_stat in db.read(SHADOW_SCHEDULER_STATS_DB)
     }
     logger.info(
-        f"Already gathered statistics for {len(known_scheduler_stats)} pushes..."
+        "Already gathered statistics for %d pushes...",len(known_scheduler_stats)
     )
 
     to_date = datetime.utcnow() - relativedelta(days=3)

scripts/test_scheduling_history_retriever.py

@@ -158,7 +158,7 @@ def retrieve_from_cache(push):
                         next_from_date = to_date
 
                     logger.info(
-                        f"Retrieving pushes from {from_date} to {next_from_date}..."
+                        "Retrieving pushes from %s to %s...",from_date,next_from_date
                     )
 
                     pushes = mozci.push.make_push_objects(