refactor count_bugs to use libmozdata (#3676) #3704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @issamarabi. Thank you for your interest in the project. See my feedback below and
please test the function locally to make sure that things work as expected.
| def handler(bug): | ||
| counts.append(bug["bug_count"]) | ||
|
|
||
| Bugzilla(bug_query_params, bughandler=handler).get_data().wait() |
There was a problem hiding this comment.
Using bughandler expect to receive a response that has the property bugs: https://bugzilla.mozilla.org/rest/bug?id=1234567. However, passing the count_only returns JSON object that contains bug_count: https://bugzilla.mozilla.org/rest/bug?id=1234567&count_only=1
Thus, you need to pass the Query class to handle this, example:
Bugzilla(queries=Query(Bugzilla.API_URL, bug_query_params, handler)).wait()
|
Closing for lack of response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3676
Refactored the
count_bugsfunction in bugbug/bugzilla.py to utilize theBugzillaclass fromlibmozdata.bugzillainstead of making a direct request.The previous approach involved sending a direct GET request to Bugzilla's REST API. This approach might not be sustainable and consistent in the long run, especially if there are updates or changes to the API.
By using the
libmozdata.bugzillalibrary, we aim for a more maintainable and robust method of counting bugs. It also keeps our codebase consistent with other parts where theBugzillaclass is used.