MNTOR-4028: Allow renewing after receiving an expiration email #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We email people that their subscription is about to expire, then mark them as having received the email. We check whether we have marked someone as having received the email when collecting the list of subscribers to email, which means that we shouldn't use that list when determining whether someone can renew. I've updated it to use a similar check, but to skip the check for `churn_prevention_email_sent_at`.
Vinnl
commented
Feb 4, 2025
| @@ -59,6 +59,29 @@ async function getAllSubscriberChurns(): Promise<SubscriberChurnRow[]> { | |||
| } | |||
| } | |||
|
|
|||
| async function getUpcomingChurns(): Promise<Array<SubscriberChurnRow>> { | |||
There was a problem hiding this comment.
This is the same as the getChurnsToEmail query, with the join and churn_prevention_email_sent_at check removed.
|
Preview URL 🚀 : https://blurts-server-pr-5587-mgjlpikfea-uk.a.run.app |
flozia
approved these changes
Feb 4, 2025
|
Cleanup completed - database 'blurts-server-pr-5587' destroyed, cloud run service 'blurts-server-pr-5587' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-4028
Figma:
Description
We email people that their subscription is about to expire, then mark them as having received the email. We check whether we have marked someone as having received the email when collecting the list of subscribers to email, which means that we shouldn't use that list when determining whether someone can renew.
I've updated it to use a similar check, but to skip the check for
churn_prevention_email_sent_at.How to test
Create a
.csvfile with the following contents:Replace
18b8ea3c9b12427893ded71fda0cb8aawith thefxa_uidof the subscriber you want to email. (This subscriber should have Plus; you can give them Plus via/admin/dev.) Then upload that file via/admin/churn-subscribers/. It should say that there's one customer to email in the next cron run.Then, run that cron job through
npm run dev:cron:churn-discount. The customer should receive an email.If you click the CTA in that email with
mainchecked out, you should see "Your Monitor Plus subscription is still active", whereas on this branch, you should be able to renew successfully.Checklist (Definition of Done)