Fix running E2E tests locally #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozia
force-pushed
the
local-e2e-tests
branch
from
322be71 to
1f7f18b
Compare
flozia
force-pushed
the
local-e2e-tests
branch
from
1f7f18b to
51d5bf2
Compare
|
Preview URL 🚀 : https://blurts-server-pr-5583-mgjlpikfea-uk.a.run.app |
1 similar comment
|
Preview URL 🚀 : https://blurts-server-pr-5583-mgjlpikfea-uk.a.run.app |
|
Might want to assign https://mozilla-hub.atlassian.net/browse/MNTOR-3916 to yourself :) |
Vinnl
approved these changes
Feb 3, 2025
|
Cleanup completed - database 'blurts-server-pr-5583' destroyed, cloud run service 'blurts-server-pr-5583' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
sharpis not available, running the E2E tests fails with an error. This PR includessharpoptionally as an NPM package.Also: Now after testing the testing of the landing experiment on
stageis done and we are all set up to run experiments via experimenter again we can have the experiment not enabled by default — this is currently causing the E2E test suite to fail.How to test
Run the E2E tests locally with
npm run e2e:smoke.