Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document various online signal smoothing algorithms #1014

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Jan 26, 2025

No description provided.

@AndyZe AndyZe changed the title Document varios online signal smoothing algorithms Document various online signal smoothing algorithms Jan 26, 2025
@AndyZe AndyZe force-pushed the document_smoothing_options branch from 48a90b8 to d43a869 Compare January 26, 2025 16:16
@AndyZe AndyZe force-pushed the document_smoothing_options branch from d43a869 to de95de9 Compare January 26, 2025 16:20
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition!


`online_signal_smoothing::RuckigFilterPlugin`: This uses the well-known Ruckig library to ensure robot motions always obey joint and acceleration limits. Read more at https://github.com/moveit/moveit2/pull/2956

Benefits: The smoothest option. Required for certain industrial robots.
Copy link
Contributor

@sea-bass sea-bass Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to clarify this is the smoothest in the joint/actuator space, but not necessarily Cartesian/task space (the drawback is something you already mention in less technical terms below)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't necessarily agree, it's still smooth in Cartesian space. Just doesn't necessarily move in the desired direction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@sea-bass
Copy link
Contributor

Sorry, one more optional comment. It might be useful to say that these plugins are... well, plugins, and that users can also create their own for more advanced/custom use cases.

doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved

`online_signal_smoothing::RuckigFilterPlugin`: This uses the well-known Ruckig library to ensure robot motions always obey joint and acceleration limits. Read more at https://github.com/moveit/moveit2/pull/2956

Benefits: The smoothest option. Required for certain industrial robots.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't necessarily agree, it's still smooth in Cartesian space. Just doesn't necessarily move in the desired direction.

doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
@AndyZe AndyZe merged commit 82e1178 into moveit:main Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants