-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document various online signal smoothing algorithms #1014
Conversation
48a90b8
to
d43a869
Compare
d43a869
to
de95de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition!
|
||
`online_signal_smoothing::RuckigFilterPlugin`: This uses the well-known Ruckig library to ensure robot motions always obey joint and acceleration limits. Read more at https://github.com/moveit/moveit2/pull/2956 | ||
|
||
Benefits: The smoothest option. Required for certain industrial robots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to clarify this is the smoothest in the joint/actuator space, but not necessarily Cartesian/task space (the drawback is something you already mention in less technical terms below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't necessarily agree, it's still smooth in Cartesian space. Just doesn't necessarily move in the desired direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Sorry, one more optional comment. It might be useful to say that these plugins are... well, plugins, and that users can also create their own for more advanced/custom use cases. |
|
||
`online_signal_smoothing::RuckigFilterPlugin`: This uses the well-known Ruckig library to ensure robot motions always obey joint and acceleration limits. Read more at https://github.com/moveit/moveit2/pull/2956 | ||
|
||
Benefits: The smoothest option. Required for certain industrial robots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't necessarily agree, it's still smooth in Cartesian space. Just doesn't necessarily move in the desired direction.
No description provided.