Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attached object colors as is in Rviz plugin (backport #3274) #3277

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 27, 2025

Description

Fixes #3273. As explained in #3273, there is some weird code from 2013 that messes up the colors of attached objects in rviz, overriding the colors provided via the planning scene interface with potentially out of range values. This removes the erroneous code and just passes the colors as is.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3274 done by [Mergify](https://mergify.com).

Fixes #3273

Co-authored-by: Sebastian Castro <[email protected]>
(cherry picked from commit 870b23d)
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.42%. Comparing base (8d89f73) to head (01416ca).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...gin_render_tools/src/robot_state_visualization.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3277      +/-   ##
==========================================
+ Coverage   51.40%   51.42%   +0.02%     
==========================================
  Files         382      382              
  Lines       31896    31894       -2     
==========================================
+ Hits        16394    16398       +4     
+ Misses      15502    15496       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 343b897 into humble Jan 27, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3274 branch January 27, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants