Fix: misleading error logs in RobotState::setFromIKSubgroups() #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misleading log message for RobotState::setFromIKSubgroups() when checking consistency_limits size
sea-bass
added
backport-humble
sea-bass
previously approved these changes
Jan 23, 2025
sea-bass
changed the title
|
Seems there are some formatting errors. Please run |
|
clang-format fixed @sea-bass |
sea-bass
approved these changes
Jan 24, 2025
rhaschke
added a commit
to ubi-agni/moveit
that referenced
this pull request
Jan 24, 2025
rhaschke
added a commit
to ubi-agni/moveit
that referenced
this pull request
Jan 24, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
- Coverage 45.97% 45.95% -0.01%
==========================================
Files 716 716
Lines 62394 62394
Branches 7545 7543 -2
==========================================
- Hits 28677 28669 -8
- Misses 33551 33557 +6
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* Fix: misleading error logs misleading log message for RobotState::setFromIKSubgroups() when checking consistency_limits size * fix clang-format (cherry picked from commit 524ca4f)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* Fix: misleading error logs misleading log message for RobotState::setFromIKSubgroups() when checking consistency_limits size * fix clang-format (cherry picked from commit 524ca4f) # Conflicts: # moveit_core/robot_state/src/robot_state.cpp
This was referenced Jan 24, 2025
sea-bass
pushed a commit
that referenced
this pull request
Jan 25, 2025
#3266) (cherry picked from commit 524ca4f) Co-authored-by: Zhong Jin <[email protected]>
sea-bass
pushed a commit
that referenced
this pull request
Jan 25, 2025
…ort #3263) (#3267) (cherry picked from commit 524ca4f) Co-authored-by: Zhong Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
misleading log message for RobotState::setFromIKSubgroups() when checking consistency_limits size
before:
fixed: